Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate .contains() and .shadow() to queries #23804

Closed
BlueWinds opened this issue Sep 13, 2022 · 0 comments
Closed

feat: Migrate .contains() and .shadow() to queries #23804

BlueWinds opened this issue Sep 13, 2022 · 0 comments
Assignees
@BlueWinds
Milestone
Detached DOM - In...

Comments

@BlueWinds
Copy link
Contributor

What would you like?

As part of #7306, and building upon #23550, we're migrating additional commands to be queries. This PR is one part of that; It can be done piece-by-piece.

Why is this needed?

Queries don't suffer from Detached DOM errors. They are also significantly simpler to write and debug than commands - less code to maintain, and what code is there is more straightforward.

Other

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlueWinds BlueWinds

Labels
None yet
Projects
None yet
Milestone
Detached DOM - Initial Release
Development

No branches or pull requests
1 participant
@BlueWinds