-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcuts #248
Comments
And |
Those Feels When you've done some prep work for an issue, paused it for a bit to work on something else, come back to the issue ready to start work in earnest... and then you spot the Just kidding 😛 For the first timer that picks this up the Cypress package in which you might choose to add implementation is the That package has Cypress tests: you might start by writing some Cypress tests that'll initially fail -- 'cos you'll not have added the keyboard shortcuts yet -- but will go green once you do. Have fun! Tag me when this is done so that I might sing your name to the heavens 😄 |
Hi! is it cool if I work on this for Hacktoberfest? |
@durangatan Absolutely! |
I'm having a hard time getting the cypress tests in the reporter package to run; when they start up I get |
Sorry about that. The reporter's Cypress tests needed some attention. Historically, the reporter has only been unit tested and the 2 Cypress tests are more recent additions. They weren't set up to run in CI, which is why we never caught this issue. That said, I think this it's good to add Cypress tests for this feature. I've fixed the issues and the reporter's Cypress tests now run in CI. Pull down the latest |
Some work has been done on this issue, but requires being handed off to someone else, so this is free to be picked up and finished. |
I think that would be a great feature and would like to try to implement it. Is that cool for everyone? edit: After reading your code guide I found that pkg/reporter is already tagged 😄 so this might be the package where I should start to look 😅 |
I was wondering which component would be the best one to listen to |
There was a PR created to address this but the author wasn't able to finish it. I'd take a look at that for an idea, but start fresh. Check out my comment on where/how I'd recommend implementing this. |
* add keyboard shortcuts lib to the reporter cypress-io#248 * add shortcuts to main.jsx cypress-io#248 * add appState param and other cases to shortcuts.js * remove events that are not coded to work yet * Write tests for shortcuts in reporter Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Can you add shortcut for selector playground? I think it will be very useful. |
This is very low priority for us, so our team will likely not pick this up. You're welcome to open a PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck. |
@chrisbreiding @jennifer-shehane I have opened this PR to address this issue 🚀 |
The code for this is done in cypress-io/cypress#16411, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Add keyboard shortcuts for common actions in the Cypress UI. Examples (with possible shortcuts) are:
Re-running the tests (R)Added in Add keyboard shortcuts #3943Stopping the tests (S)Added in Add keyboard shortcuts #3943Focus the tests (F)Added in Add keyboard shortcuts #3943Also, evaluate the keyboard-friendliness of the UI. Is it easy to tab through various UI elements? Do UI elements have proper focus styles? We may need to add enhancements like responding to down arrow, left arrow, etc to focus tests and commands, move through them, expand/collapse them, etc.
Since the shortcuts map exactly to the UI elements we already have - there should be updates to the UI to help indicate to users which key to press. As it stands, there's no way for users to have any idea these exist at all (or what they do).
The text was updated successfully, but these errors were encountered: