Visually highlight the focused spec when navigating via the keyboard #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating through the specs using the `{tab}` key there was no visual feedback about which spec was currently focused. With this change you get the same visual feedback as you do when hovering over a spec with the mouse.
|
|
|
Oh boy, yeah - I'll have to manually test this. There may be some hacky tab support I could work in. |
jennifer-shehane
approved these changes
Aug 6, 2018
|
Any updates on this being implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visually highlight the focused spec when navigating via the keyboard
When navigating through the specs using the
{tab}key there was no visual feedback about which spec was currently focused. With this change you get the same visual feedback as you do when hovering over a spec with the mouse.Noticed while prepping for #248, specifically this comment:
Before
It's not obvious from this screenshot but the second spec
fixtures_spec.coffeeis focused and will run if you hit{enter}.After
It's immediately obvious that the second spec is focused. Hitting
{enter}will run the spec.Tests?
Uhh... 😳 😰 This team asks the hard questions 😄
There's no
{tab}support yet: see #299. I did look atspecs_list_spec.coffeebut yeah, without explicit support for{tab}I wasn't seeing a straightforward way through to testing this. If there is then I'm listening.