Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement custom resizable box for specs list #14894

Closed
wants to merge 510 commits into from
Closed

feat: Implement custom resizable box for specs list #14894

wants to merge 510 commits into from

Conversation

dmtrKovalenko
Copy link
Contributor

Implement resizing for specs list drawer:

Screen.Recording.2021-02-03.at.17.49.12.mov

brian-mann and others added 30 commits January 4, 2021 20:39
@brian-mann
convert packages/socket to .ts, update packages/extension to .ts + im…
34751c2 
…ports
@brian-mann
convert packages socket -> ts, upgrade socket.io to 3.x.x
4240232 
- TODO: need to fix our custom circular parser to work with socket.io
engine 3.x.x
@brian-mann
replace browserify with webpack in packages/extension
39cd18a
@brian-mann
finished consolidating and refactoring socket-base, socket-e2e, and s…
342b05c 
…ocket-ct

- move all reusable logic into socket-base, only split out what is
different in each socket class
@brian-mann
use automation api's to reset server state and browser state before e…
3ff21b9 
…ach test
@brian-mann
remove custom parser
b73871d
@brian-mann
remove additional circularParser ref
3ba598b
@lmiller1990
types: fix types (#14401)
116fdf2 
* types: fix types

* types: use target es6

* types: use Promise for async/await

* types: lint
@lmiller1990
fix: add xhrs
f4f07df
@lmiller1990
wip: work on linting
a58228a
@lmiller1990
chore: linting
50fce54
@brian-mann
convert lib/automation into typescript
93a8085 
- add middleware interfaces
@brian-mann
convert automation/screenshot into typescript
ca0a7d1
@brian-mann
convert automation/cookies into typescript
97c3dbf
@brian-mann
let -> const
70d7dd2
@brian-mann
create ensureProp class helper to validate that properties are available
ef7dc68 
- provide good error reason as to why the property isn’t yet available
- use TS generics for proper type autocompletion
@brian-mann
move around specific e2e method
2192d3f
@brian-mann
fix a bunch of types, improve type completion
0be806f
@brian-mann
consolidate createRoutes
5e26100
@brian-mann
add ts-no-check again
7e6d19f
@brian-mann
dont check this file either
57208ef
@lmiller1990
types: remove return type
16ed422
@brian-mann
fix failing tests, listen to 'error' not 'connect_error' event due to…
86b4503 
… socket v3
@brian-mann
dont use it.only
2113d9e
@lmiller1990
fix: correctly use new for automation class
277088a
@brian-mann
properly bind the automation#response method so it has access to this…
b9951ae 
….requests
@lmiller1990
fix: add missing get function
7e03f2b
@lmiller1990
fix: use this to get correct ctx
94d561c
@lmiller1990
fix: use new screenshot class correctly
23e61d1
@brian-mann
reset the maxHttpBufferSize in socket.io server to be the previous v2
b9f432e
@dmtrKovalenko dmtrKovalenko requested a review from a team February 3, 2021 16:08
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 3, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 3, 2021 •
edited
Loading


Test summary

9309 • 1 • 118 • 3

Run details
Project cypress
Status Failed
Commit bc0adea
Started Feb 4, 2021 7:13 PM
Ended Feb 4, 2021 7:26 PM
Duration 12:56 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

cypress/integration/commands/navigation_spec.js 1 Failed
1 ... > throws passing 1 invalid argument

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs
Copy link
Contributor

Oh the text highlight is a bummer. How do you think we should solve it?

JessicaSachs
JessicaSachs reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the custom ResizeableBox component. Happy to have finer-grained control over the resizing behavior than what split pane's api was giving us. I want to hear your ideas about fixing the text highlight situation. What do you think we should do?

@elevatebart
Copy link
Contributor

We could play with user-select when dragging.

@elevatebart
Copy link
Contributor

We should also absolutely avoid the wrapping of the file names... that's ugly, but out of scope for this request.

@JessicaSachs
Copy link
Contributor

We could play with user-select when dragging.

Yeah that was my initial thought... I want to be able to select the text when the user clicks on it though.... right?

@elevatebart
Copy link
Contributor

Yes, but we can add a class on the body and remove it when release.

Base automatically changed from feat/component-testing to develop February 4, 2021 20:45
This was referenced Feb 5, 2021
Merged
Closed
@dmtrKovalenko
Copy link
Contributor Author

Closed in favor of #14940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaSachs JessicaSachs JessicaSachs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmtrKovalenko @JessicaSachs @elevatebart @brian-mann @lmiller1990 @flotwig