feat(component-testing): Make specs-list resizeable #14940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
elevatebart
approved these changes
Feb 5, 2021
| className="specs-list-container" | ||
| data-cy="specs-list-resize-box" | ||
| minWidth={200} | ||
| maxWidth={windowSize.width / 100 * 80} // 80vw |
There was a problem hiding this comment.
If you open the specs-list at maximum, then reduce the size of the window, the spec list will not size down.
It feels like it should. But this can be taken care of in a future PR.
There was a problem hiding this comment.
I think that it is desired behavior. I am not sure one more resize observer is really required here..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement resizing for specs list drawer:
Screen.Recording.2021-02-03.at.17.49.12.mov
runner-ct tests
Also fixed current runner-ct tests, added a couple of tests for the root
Appcomponent, add percy snapshots and make all of this run on CI.