Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): change open_project to TS and define some interfaces #17908

Closed
wants to merge 3 commits into from

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Aug 27, 2021

Replaces: #17850

!! NO SQUASH !!

As for the PR: no changes in functionality.

  • Knowing what values are defined on args and options is very useful when launching a runner. It's very hard to remember, so I changed open_project to TypeScript and defined some interfaces, like args and options.
  • I changed from using a moduleFactory pattern (which is basically just re-creating ES6 class) to just using a regular ES6 class
  • using a named export to integrate better with TypeScript

@lmiller1990 lmiller1990 requested a review from a team as a code owner August 27, 2021 02:10
@lmiller1990 lmiller1990 requested review from chrisbreiding and jennifer-shehane and removed request for a team August 27, 2021 02:10
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 27, 2021



Test summary

4183 0 50 2Flakiness 1


Run details

Project cypress
Status Passed
Commit b275d14
Started Aug 27, 2021 4:11 AM
Ended Aug 27, 2021 4:21 AM
Duration 09:48 💡
OS Linux Debian - 10.9
Browser Electron 91

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants