chore(graphql): make tsconfig more strict #17909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
requested review from
chrisbreiding and
jennifer-shehane
and removed request for
a team,
chrisbreiding and
jennifer-shehane
lmiller1990
commented
Aug 27, 2021
| @@ -7,6 +7,7 @@ | |||
| // "allowJs": true, /* Allow javascript files to be compiled. */ | |||
| // "checkJs": true, /* Report errors in .js files. */ | |||
| "jsx": "react", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
Need this or it complains about duplicate global types like mocha... would be nice to remove, not entirely sure how
There was a problem hiding this comment.
Yep, working though this in a separate PR, there's a bunch of cruft that we have in our tsconfig & d.ts files that can be removed to help here.
tgriesser
reviewed
Aug 27, 2021
tgriesser
reviewed
Aug 27, 2021
tgriesser
approved these changes
Aug 27, 2021
tgriesser
added a commit
that referenced
this pull request
Sep 1, 2021
…p-gui-gql-stitching * unified-desktop-gui: fix: rename testApolloClient -> testUrqlClient, add apollo.config.js (#17948) feat(launchpad): detect if runner is set up and change UI accordingly (#17934) rebuild yarn lock chore: remove skipLibCheck, re-add vue-tsc, fix types (#17924) fix: ensure @headlessui/vue is bundled chore(graphql): make tsconfig more strict (#17909) run vite during watch fix: source maps while developing electron rebuild schema w/o JS files make constant more generic remove hanging tests allow larger artifacts comment out flaky test fix typing errors make graphql tsconfig more minimal chore: use `import type` syntax (#17864) remove browser-specific `beforeinput` checks (send in firefox) (#17820) fix(types): Update title method options type (#17781) fix(deps): update dependency @cypress/request to v2.88.6 🌟 (#17813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typespackageserver,browseretcskipLibCheckis still required, I don't think this is a big deal though.Will cherry pick the
typespackage back to develop once #17908 is merged.