-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support specPattern, deprecate integrationFolder and componentFolder #19319
Merged
lmiller1990
merged 146 commits into
10.0-release
from
lmiller1990/update-spec-patter-change-path
Jan 4, 2022
Merged
feat: support specPattern, deprecate integrationFolder and componentFolder #19319
lmiller1990
merged 146 commits into
10.0-release
from
lmiller1990/update-spec-patter-change-path
Jan 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
previously approved these changes
Dec 15, 2021
ryanthemanuel
previously approved these changes
Dec 20, 2021
lmiller1990
dismissed stale reviews from ryanthemanuel and chrisbreiding
via
January 3, 2022 09:08
c273335
…pdate-spec-patter-change-path
…pdate-spec-patter-change-path
tgriesser
added a commit
that referenced
this pull request
Jan 4, 2022
* 10.0-release: feat: support specPattern, deprecate integrationFolder and componentFolder (#19319) refactor: remove concept of liveMutation (#19528) chore: Adding `validateExternalLink` command to increase e2e coverage of external links (#19462) chore: remove vite-plugin-favicon, add a simple favicon path (#19527) feat: implement the ui for migration to 10.0 (#19371)
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented here (Cypress team only): https://www.notion.so/cypressdx/testFiles-specPattern-glob-patterns-295d545a0af942ebb5b71eda2a6d422b
testFiles
,integrationFolder
,component
, superseded byspecPattern
, configurable oncomponent
ande2e
important this PR is really big since the concept of
integrationFolder
is sprinkled throughout the entire system. The main, important, and possibly breaking change is explained here: https://github.com/cypress-io/cypress/pull/19319/files#r765721951 please read this comment and ask if you have any concerns. @cowboy is the main person to talk to about this change in behavior.Before
After
Scaffolding
cypress/integration
is goneOur scaffolding logic is very closely tied to
cypress/integration
existing. Since we no longer scaffold by default on first use, instead using a visual wizard to let the user choose which specs they'd like to scaffold, I deleted all this code and relevant tests.util/spec.ts
is goneNow using the
findSpecs
method in data-context, which does the same thing with much less indirection, not relying onintegration
orcomponent
folders any more, instead just using the newspecPattern
property. We only hit the file system once, then caching the specs inctx.currentProject.specs
, making it nice and quick.Breaking change for
@cypress/code-coverage
No
integrationFolder
is a breaking change for code coverage. I patched it locally to get CI passing for now: https://github.com/cypress-io/cypress/pull/19319/files#diff-84b549ff6d349070e8dfaf1b1713e4213274611342147dfcc2456848147d72f6. We will need to figure out the migration strategy here. Made an issue here.Coming in future PR
cypress/integration/**/*
instead ofcypress/e2e/**/*.cy.js
ignoreTestFiles
toignoreSpecPattern
As outlined in notion, we are changing the default directory for e2e from
cypress/integration
tocypress/e2e
. Changing the default means changing all our projects insystem-tests/projects
(all 89 of them) and all the ones innpm
. It's easy but adds a lot of noise to the PR. For this reason, I'll do those in a separate PR (WIP HERE).