refactor: remove concept of liveMutation #19528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
tgriesser
requested review from
estrada9166,
lmiller1990,
ZachJW34 and
ImCesar
estrada9166
previously approved these changes
Jan 3, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||
estrada9166
previously approved these changes
Jan 3, 2022
lmiller1990
previously approved these changes
Jan 4, 2022
|
Gave it a test, works fine. Added missing urql key as a drive by fix d8805ff |
tgriesser
added a commit
that referenced
this pull request
Jan 4, 2022
* 10.0-release: feat: support specPattern, deprecate integrationFolder and componentFolder (#19319) refactor: remove concept of liveMutation (#19528) chore: Adding `validateExternalLink` command to increase e2e coverage of external links (#19462) chore: remove vite-plugin-favicon, add a simple favicon path (#19527) feat: implement the ui for migration to 10.0 (#19371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
liveMutationwas always meant to be a temporary hack while we got our caching, querying, and subscription patterns down. Now that we're getting closer on this, it should be removed, as it's very naive and produces unnecessary queries. We should resort to the GraphQL practice of "querying for what is updated" on a mutation.