test: ct audit updates #19464
Merged
test: ct audit updates #19464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
elevatebart
approved these changes
Jan 6, 2022
| {{ t('createSpec.viewSpecPatternButton') }} | ||
| </Button> | ||
| </router-link> | ||
| <Button |
There was a problem hiding this comment.
could we simply have added custom to the router link?
https://next.router.vuejs.org/api/#custom
There was a problem hiding this comment.
Ooh possibly, I didn't know about custom. I still like the API of our button component accepting to & href - it mirrors Vuetify's v-btn API. I'm open to revisit this soon though, there's currently only this one case where we are using it so a refactor would be low-effort.
tgriesser
added a commit
that referenced
this pull request
Jan 7, 2022
* 10.0-release: chore: remove unused components (#19618) fix: dev-server types (#19576) test: ct audit updates (#19464) chore: fix temporarily skipped specs on 10.0-release (#19611) fix: remove gremlins characters from cypress types freeze ipc fix test test(launchpad): add e2e tests for Project View - Global mode (#19267) test(unify): Left Nav E2E Additional Tests (#19428)
tgriesser
added a commit
that referenced
this pull request
Jan 7, 2022
* 10.0-release: chore: remove unused components (#19618) fix: dev-server types (#19576) test: ct audit updates (#19464) chore: fix temporarily skipped specs on 10.0-release (#19611) fix: remove gremlins characters from cypress types freeze ipc fix test test(launchpad): add e2e tests for Project View - Global mode (#19267) test(unify): Left Nav E2E Additional Tests (#19428) ci: publish test artifacts for frontend-shared & app too (#19592) fix: union type to work in graphql tests (#19447)
tgriesser
added a commit
that referenced
this pull request
Jan 13, 2022
* 10.0-release: (28 commits) fix: flake in shelljs scripts during postinstall (#19678) fix: various lifecycle issues, followup to #19572 (#19683) feat: error screens in app when cloud runs are failing (#18980) fix: open browser at correct time during lifecycle (#19572) chore: remove unused types (#19621) fix: fileparts processing and cleanup (#19660) chore: change integration->e2e throughout code base (#19345) fix(unify): correct location of snapshot pinning UI in runner (#19640) fix: runnable header open in IDE and filename (#19630) feat(unify): allow prompts to auto-open after set time (#19571) test(unify): Additional navigation tests for log in workflows (#19574) fix(unify): minor UI bugs in the reporter (#19445) fix: surface openSSL unhandled rejection errors that occur within plugin code (#19598) feat: add spec watcher to data-context (#19583) chore: remove unused components (#19618) fix: dev-server types (#19576) test: ct audit updates (#19464) chore: fix temporarily skipped specs on 10.0-release (#19611) fix: remove gremlins characters from cypress types freeze ipc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://cypress-io.atlassian.net/browse/UNIFY-867
User facing changelog
Additional details
This PR adds a
toprop to our button that works like ourhrefprop - when used, it causes the button to render a Router Link. This allows us to avoid wrapping a the Button in a Router Link, which creates invalid mark up of abuttonelement inside anaelement.This PR also adds a bit of testing to the NoSpecsPage, and adds ticket number to TODO comments. The tailwind class changes are just changing the order due to the files formatting automatically when saved.
How to test
Run
NoSpecsPage.spec.tsxand validate the that markup around the View Spec pattern button is a link, not a link wrapping a button. Or remove/rename the specs in a project so that you get the same page in the App.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?