fix: runnable header open in IDE and filename #19630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||
elevatebart
reviewed
Jan 10, 2022
packages/reporter/src/main.tsx
Outdated
| @@ -122,7 +122,7 @@ class Reporter extends Component<SingleReporterProps> { | |||
|
|
|||
| shortcuts.start() | |||
| EQ.init() | |||
| this.props.runnablesStore.setRunningSpec(spec.relative) | |||
| this.props.runnablesStore.setRunningSpec(this.props.runnerStore.spec.relative) | |||
There was a problem hiding this comment.
Could runnerStore be destructured like the rest of the props for consistency?
packages/reporter/src/main.tsx
Outdated
| if (window.Cypress) { | ||
| window.state = appState | ||
| window.render = (props) => { | ||
| if (_window.Cypress) { |
There was a problem hiding this comment.
Could you add a comment about why the _ ?
Is it to avoid TypeScript validation?
If it is, use expect error more than any if you can.
You could also augment the window object if you need to.
There was a problem hiding this comment.
This was before I added lib: ["DOM"] to the tsconfig.json, I can remove the these changes
| import TextIcon from '-!react-svg-loader!@packages/frontend-shared/src/assets/icons/document-text_x16.svg' | ||
| import FileNameOpener from '../lib/file-name-opener' |
There was a problem hiding this comment.
This move threw me off for a bit ;)
There was a problem hiding this comment.
I blame it on VS code!
|
@elevatebart Everything should be passing, is this with regards to the CI tests or the changes made to the reporter tests? |
|
@ZachJW34 I was referring to CI |
|
@elevatebart All passing now! |
tgriesser
added a commit
that referenced
this pull request
Jan 11, 2022
* 10.0-release: chore: change integration->e2e throughout code base (#19345) fix(unify): correct location of snapshot pinning UI in runner (#19640) fix: runnable header open in IDE and filename (#19630) feat(unify): allow prompts to auto-open after set time (#19571) test(unify): Additional navigation tests for log in workflows (#19574) fix(unify): minor UI bugs in the reporter (#19445) fix: surface openSSL unhandled rejection errors that occur within plugin code (#19598) feat: add spec watcher to data-context (#19583)
tgriesser
added a commit
that referenced
this pull request
Jan 13, 2022
* 10.0-release: (28 commits) fix: flake in shelljs scripts during postinstall (#19678) fix: various lifecycle issues, followup to #19572 (#19683) feat: error screens in app when cloud runs are failing (#18980) fix: open browser at correct time during lifecycle (#19572) chore: remove unused types (#19621) fix: fileparts processing and cleanup (#19660) chore: change integration->e2e throughout code base (#19345) fix(unify): correct location of snapshot pinning UI in runner (#19640) fix: runnable header open in IDE and filename (#19630) feat(unify): allow prompts to auto-open after set time (#19571) test(unify): Additional navigation tests for log in workflows (#19574) fix(unify): minor UI bugs in the reporter (#19445) fix: surface openSSL unhandled rejection errors that occur within plugin code (#19598) feat: add spec watcher to data-context (#19583) chore: remove unused components (#19618) fix: dev-server types (#19576) test: ct audit updates (#19464) chore: fix temporarily skipped specs on 10.0-release (#19611) fix: remove gremlins characters from cypress types freeze ipc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Add filename to reporter runnables header and ensure update of filename and open in IDE path when selected spec changes
Additional details
The reporter runnables header didn't show the filename and and the open in IDE path became stale when switching specs (it would only open the first spec that was selected). We now pass in the runnerStore so that React can update when the runnerStore updates.
How has the user experience changed?
Screen.Recording.2022-01-10.at.9.52.28.AM.mov
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?