fix: firefox 93 error issues

[AtofStryker]

• Closes N/A

User facing changelog

N/A

Additional details

The goal of this PR is to fix a bug that was discovered in #20561 through some of the serialization changes introduced earlier. This error only occurs in Firefox 93 and below in run mode. There are two fixes here:

a) don't fail serialization if object prototype accessors throw a TypeError due to some caveats of certain data types (ex: DOMException. Fixing this yields the following, which serialize the security error back to the primary:

b) Because of the issues discovered with fixing a), the next step was to make sure commands fail gracefully in the spec bridge even after we leave the domain. This is accomplished by resetting document and window state in the specbridge after unload to prevent any type of stale DOM cross-origin errors. This yields the expected result:

It's a bit of a mystery to me why this only happens in Firefox in run mode. I would think stale DOM references after the spec bridge exits would be common security errors in other browsers. I think this might bring up another area of concerns as to where document and window state are being used elsewhere, and if there is any need to persist any of this state between invocations of the spec bridge

How has the user experience changed?

N/A

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

20503 • 0 • 294 • 4 • 3

---

Run details

Project	cypress
Status	Passed
Commit	86a710c
Started	Mar 21, 2022 9:37 PM
Ended	Mar 21, 2022 9:51 PM
Duration	14:30 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	reporter.hooks.spec.js		2
1	hooks > can rerun without timeout error leaking into next run (due to run restart)
2	hooks > can rerun without timeout error leaking into next run (due to run restart)
	cy/timers_spec.js		1
1	driver/src/cy/timers > can cancel setIntervals paused or unpaused

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[mschile]

Since we are clearing the window now, I believe we can remove this try...catch

[AtofStryker]

Since we are clearing the window now, I believe we can remove this try...catch

@mschile are you referring to the try/catch here?

Since we are clearing the window now, I believe we can remove this try...catch

I think we still need this. Removing the try/catch consistently fails the window:before:load test. My guess is the spec bridge is created with state('window') populated, which then onLoad is fired which then causes the cross origin failure since it happens before we even unload the spec bridge which would unset the window 😢