Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: firefox 93 error issues #20695

Merged
merged 8 commits into from
Mar 22, 2022
Merged

fix: firefox 93 error issues #20695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
07459bb
don't fail serialization in cases properties are inaccessable due to …
AtofStryker Mar 18, 2022
2a59fd1
gracefully fail element lookups in case of cross origin stale documen…
AtofStryker Mar 18, 2022
c85c133
reset window and document when spec bridge exits
AtofStryker Mar 18, 2022
6c8b3cd
Merge branch 'feature-multidomain' into multi_domain_fix_firefox_erro…
AtofStryker Mar 18, 2022
3fbfb94
Merge branch 'feature-multidomain' into multi_domain_fix_firefox_erro…
mjhenkes Mar 21, 2022
12ac46a
test in firefox
mjhenkes Mar 21, 2022
6143162
Update packages/driver/cypress/integration/e2e/multi-domain/navigatio…
AtofStryker Mar 21, 2022
86a710c
Merge branch 'feature-multidomain' into multi_domain_fix_firefox_erro…
AtofStryker Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/driver/cypress/integration/e2e/multi-domain/navigation_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,7 @@ describe('errors', { experimentalSessionSupport: true }, () => {
.should('equal', 'Welcome BJohnson')
})

// TODO: run in firefox too after we fix error serialization for firefox.
it('fails in switchToDomain when a command is run after we return to localhost', { browser: '!firefox', defaultCommandTimeout: 50 }, (done) => {
it('fails in switchToDomain when a command is run after we return to localhost', { defaultCommandTimeout: 50 }, (done) => {
cy.on('fail', (err) => {
expect(err.message).to.include(`Timed out retrying after 50ms: Expected to find element: \`[data-cy="cannot_find"]\`, but never found it`)
// make sure that the secondary domain failures do NOT show up as spec failures or AUT failures
Expand Down
2 changes: 2 additions & 0 deletions packages/driver/src/multi-domain/cypress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ const onBeforeAppWindowLoad = (Cypress: Cypress.Cypress, cy: $Cy) => (autWindow:
Cypress.specBridgeCommunicator.off('window:load', onWindowLoadPrimary)
},
onUnload (e) {
cy.state('window', undefined)
cy.state('document', undefined)
// We only need to listen to this if we've started an unload event and the load happens in another spec bridge.
Cypress.specBridgeCommunicator.once('window:load', onWindowLoadPrimary)

Expand Down
17 changes: 15 additions & 2 deletions packages/driver/src/util/serialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,21 @@ const convertObjectToSerializableLiteral = (obj): typeof obj => {
const props = Object.getOwnPropertyNames(currentObjectRef)

props.forEach((prop: string) => {
if (!allProps.includes(prop) && isSerializableInCurrentBrowser(currentObjectRef[prop])) {
allProps.push(prop)
try {
if (!allProps.includes(prop) && isSerializableInCurrentBrowser(currentObjectRef[prop])) {
allProps.push(prop)
}
} catch (err) {
/**
* In some browsers, properties of objects on the prototype chain point to the implementation object.
* Depending on implementation constraints, these properties may throw an error when accessed.
*
* ex: DOMException's prototype is Error, and calling the 'name' getter on DOMException's prototype
* throws a TypeError since Error does not implement the DOMException interface.
*/
if (err?.name !== 'TypeError') {
throw err
}
}
})

Expand Down