fix: add alternative binary names for edge-beta #25456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add alternative binary names for edge-beta and edge-canary to allow matching microsoft-edge-beta and microsoft-edge-canary Also updates snapshots to include alternate binary names
|
|
4 tasks
emilyrohrbough
approved these changes
Jan 25, 2023
AtofStryker
approved these changes
Jan 25, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 26, 2023
* develop: (27 commits) refactor: remove unused cloud routes (#25584) chore: fix issue template formatting issue (#25587) fix: fixed issue with CT + electron + run mode not exiting properly (#25585) chore(deps): update dependency ua-parser-js to v0.7.33 [security] (#25561) fix: add alternative binary names for edge-beta (#25456) chore: add batch execution to CloudDataSource (#22457) chore: End a/b campaigns for aci smart banners (#25504) chore: release @cypress/schematic-v2.5.0 fix(cypress-schematic): do not disable e2e support file (#25400) chore: adding memory issue template (#25559) feat: Add Angular CT Schematic (#24374) chore: enforce changelog entries on PR reviews (#25459) chore: bump package.json to 12.4.0 [run ci] (#25556) feat: Add 'type' option to `.as` to store aliases by value (#25251) chore: release @cypress/webpack-dev-server-v3.2.3 feat: Display line break in cy.log (#25467) chore: update types (#25538) fix: Revert "fix: adding emergency garbage collection for chromium-based browsers" (#25546) fix: percy - wait to take snapshot until previous tooltips are gone (#25522) feat: support data-qa selector in selector playground (#25475) ...
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alternative binary names for edge-beta and edge-canary to allow matching microsoft-edge-beta and microsoft-edge-canary Also updates snapshots to include alternate binary names
User facing changelog
Additional details
Change done due to it only being previously applied to 2 other known edge browsers in #25455
Steps to test
Have Microsoft Edge Beta and/or Microsoft Edge Canary installed on your machine with the binary names
microsoft-edge-betaandmicrosoft-edge-canaryrespectivly. Cypress should now be able to discover these binaries installed on your machine without having to symlink toedge-betaoredge-canaryHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?