chore: End a/b campaigns for aci smart banners #25504
Conversation
| cohortOptionSelected.value = config.options.find((option) => option.cohort === cohortSelected.data?.determineCohort?.cohort) | ||
| } | ||
| const fetchCohort = async () => { | ||
| const cohortSelected = await determineCohort(name, cohortIds) |
There was a problem hiding this comment.
Do we still need to determine the cohort? Isn't there only 1 cohort now that the A/B testing ended? Is this now dead code or a no-op?
There was a problem hiding this comment.
I think we should add a comment that the infrastructure is left is place as future a/b testing is expected within this same place. I recall asking this somewhere in the original issue.
There was a problem hiding this comment.
Correct, since there are no active experiments this is currently dead code. However, product wants the ability to quickly introduce new experiments so it was requested that the logic be maintained. I will add some comments to this area to clarify
|
Looks good to me! |
There was a problem hiding this comment.
There are some questionable changes in the Percy build here. It looks like some specs list tests are showing banners when they didn't before. It's not clear to me why this is happening from looking at the diff, but we should check them out before merging.
I marked the problematic snapshot changes in the Percy build
|
@astone123 good catch... if this is a regression, we should also add a Cypress assertion as well - Percy is good, but I don't think it should be the only test, especially when it's easy do so a |
There was a problem hiding this comment.
After talking to Mike about this, the changes that I pointed out in the Percy snapshots weren't regressions, just a result of the cohorts being immediately resolved, so the banners show up during those tests when they didn't before.
We have other tests for ensuring banners only appear when they're supposed to, so I think it's fine to just update the snapshots. Looks good 👍🏻
* develop: (27 commits) refactor: remove unused cloud routes (#25584) chore: fix issue template formatting issue (#25587) fix: fixed issue with CT + electron + run mode not exiting properly (#25585) chore(deps): update dependency ua-parser-js to v0.7.33 [security] (#25561) fix: add alternative binary names for edge-beta (#25456) chore: add batch execution to CloudDataSource (#22457) chore: End a/b campaigns for aci smart banners (#25504) chore: release @cypress/schematic-v2.5.0 fix(cypress-schematic): do not disable e2e support file (#25400) chore: adding memory issue template (#25559) feat: Add Angular CT Schematic (#24374) chore: enforce changelog entries on PR reviews (#25459) chore: bump package.json to 12.4.0 [run ci] (#25556) feat: Add 'type' option to `.as` to store aliases by value (#25251) chore: release @cypress/webpack-dev-server-v3.2.3 feat: Display line break in cy.log (#25467) chore: update types (#25538) fix: Revert "fix: adding emergency garbage collection for chromium-based browsers" (#25546) fix: percy - wait to take snapshot until previous tooltips are gone (#25522) feat: support data-qa selector in selector playground (#25475) ...
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Standardizes language within in-app banners that assist users with connecting projects to the Cypress Cloud.
Additional details
Ending A/B testing campaigns for ACI project connection banners
Steps to test
Should be covered by existing tests
How has the user experience changed?
No user visible change - three banners will simply always show a chosen version of content that was already being displayed to a subset.
PR Tasks
cypress-documentation?type definitions?