Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: capture BUILDKITE_RETRY_COUNT #25750

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Feb 9, 2023

  • Closes

Additional details

Capture Buildkite env variable BUILDKITE_RETRY_COUNT - used to handle ci retries

This env variable shows how many times this job has been retried - providing a value that would ensure that ci-build-id created (if it's not custom) is unique, making every retry a new run and avoiding having a passed run where the specs have been completed in the previous run (creating a false positive)

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress
Copy link

cypress bot commented Feb 9, 2023

29 flaky tests on run #44880 ↗︎

0 26890 1281 0 Flakiness 29

Details:

Merge branch 'develop' into alejandro/feat/capture-build-retry-buildkite
Project: cypress Commit: 98decfcd0f
Status: Passed Duration: 18:20 💡
Started: Mar 22, 2023 12:49 AM Ended: Mar 22, 2023 1:07 AM
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  settings.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App: Settings without cloud > the projectId section shows a prompt to log in when there is no projectId, and uses correct UTM params Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > can be opened Output Screenshots Video

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@emilyrohrbough emilyrohrbough changed the title misc: Capture BUILDKITE_RETRY_COUNT feat: Capture BUILDKITE_RETRY_COUNT Feb 17, 2023
@emilyrohrbough
Copy link
Member

@estrada9166 Can you please update this PR summary to indicate why this env is needed and how it impacts the Cloud data?

cli/CHANGELOG.md Outdated Show resolved Hide resolved
estrada9166 and others added 2 commits March 1, 2023 11:54
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@lmiller1990 lmiller1990 changed the title feat: Capture BUILDKITE_RETRY_COUNT feat: capture BUILDKITE_RETRY_COUNT Mar 22, 2023
@lmiller1990 lmiller1990 changed the title feat: capture BUILDKITE_RETRY_COUNT chore: capture BUILDKITE_RETRY_COUNT Mar 22, 2023
@lmiller1990 lmiller1990 merged commit 98c855e into develop Mar 22, 2023
@lmiller1990 lmiller1990 deleted the alejandro/feat/capture-build-retry-buildkite branch March 22, 2023 03:13
@lmiller1990
Copy link
Contributor

Looks good 👍 🪁

@emilyrohrbough
Copy link
Member

emilyrohrbough commented Mar 22, 2023

@lmiller1990 This needed two approvals before merging. Also this didn't have a corresponding documentation updates....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants