Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: capture BUILDKITE_RETRY_COUNT #25750

Merged
merged 6 commits into from
Mar 22, 2023
Merged

chore: capture BUILDKITE_RETRY_COUNT #25750

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbd27c4
misc: Capture BUILDKITE_RETRY_COUNT
estrada9166 Feb 9, 2023
8120a84
Add changelog
estrada9166 Feb 9, 2023
0f1c4e2
Update code
estrada9166 Feb 9, 2023
300437f
Update cli/CHANGELOG.md
estrada9166 Mar 1, 2023
a079803
Merge branch 'develop' of github.com:cypress-io/cypress into alejandr…
estrada9166 Mar 3, 2023
98decfc
Merge branch 'develop' into alejandro/feat/capture-build-retry-buildkite
estrada9166 Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ _Released 03/14/2023 (PENDING)_

- It is now possible to control the number of connection attempts to the browser using the CYPRESS_CONNECT_RETRY_THRESHOLD Environment Variable. Learn more [here](https://docs.cypress.io/guides/references/advanced-installation#Environment-variables). Addressed in [#25848](https://github.com/cypress-io/cypress/pull/25848).

**Misc:**

- Capture the [Buildkite](https://buildkite.com/) CI provider's environment variable `BUILDKITE_RETRY_COUNT` to handle CI retries in the Cloud. Addressed in [25750](https://github.com/cypress-io/cypress/pull/25750).

**Dependency Updates:**

- Upgraded [`mocha-junit-reporter`](https://github.com/michaelleeallen/mocha-junit-reporter) from `2.1.0` to `2.2.0` to be able to use [new placeholders](https://github.com/michaelleeallen/mocha-junit-reporter/pull/163) such as `[suiteFilename]` or `[suiteName]` when defining the test report name. Addressed in [#25922](https://github.com/cypress-io/cypress/pull/25922).
Expand Down
1 change: 1 addition & 0 deletions packages/server/lib/util/ci_provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ const _providerCiParams = () => {
'BUILDKITE_PULL_REQUEST',
'BUILDKITE_PULL_REQUEST_REPO',
'BUILDKITE_PULL_REQUEST_BASE_BRANCH',
'BUILDKITE_RETRY_COUNT',
]),
circle: extract([
'CIRCLE_JOB',
Expand Down
2 changes: 2 additions & 0 deletions packages/server/test/unit/util/ci_provider_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ describe('lib/util/ci_provider', () => {
BUILDKITE_PULL_REQUEST: 'buildkitePullRequest',
BUILDKITE_PULL_REQUEST_REPO: 'buildkitePullRequestRepo',
BUILDKITE_PULL_REQUEST_BASE_BRANCH: 'buildkitePullRequestBaseBranch',
BUILDKITE_RETRY_COUNT: 'buildkiteRetryCount',

BUILDKITE_COMMIT: 'buildKiteCommit',
BUILDKITE_BRANCH: 'buildKiteBranch',
Expand All @@ -311,6 +312,7 @@ describe('lib/util/ci_provider', () => {
expectsCiParams({
buildkiteRepo: 'buildkiteRepo',
buildkiteJobId: 'buildkiteJobId',
buildkiteRetryCount: 'buildkiteRetryCount',
buildkiteSource: 'buildkiteSource',
buildkiteBuildId: 'buildkiteBuildId',
buildkiteBuildUrl: 'buildkiteBuildUrl',
Expand Down