Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windowsHide prop #2853

Merged
merged 3 commits into from
Dec 3, 2018
Merged

fix windowsHide prop #2853

merged 3 commits into from
Dec 3, 2018

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Nov 28, 2018 •
edited
Loading

fix #2809
fix #2667

chose to revert #2699 since windowsHide is by default false so we can just always set it to false 🙂

this prevents bringing in another dependency into the cli

@kuceb kuceb requested a review from brian-mann November 28, 2018 22:41
@brian-mann brian-mann merged commit d57ca55 into develop Dec 3, 2018
@noahblon noahblon mentioned this pull request Nov 27, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 28, 2023
Open
@emilyrohrbough emilyrohrbough deleted the windowsHide branch August 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kuceb @brian-mann