Skip to content

Commit

Permalink
integration test for deletion of series (grafana#2946)
Browse files Browse the repository at this point in the history
* integration test for deletion of series

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* update changelog

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* Reuse existing timeout

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Removed Println()

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Assert on Purger metrics too

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Removed time.Sleep() from delete series integration test

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Moved CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
sandeepsukhani and pracucci authored Aug 12, 2020
1 parent 40df163 commit f5961e6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion purger/request_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ func (dm *DeleteRequestHandler) AddDeleteRequestHandler(w http.ResponseWriter, r
}

dm.metrics.deleteRequestsReceivedTotal.WithLabelValues(userID).Inc()
w.WriteHeader(http.StatusNoContent)
}

// GetAllDeleteRequestsHandler handles get all delete requests
Expand Down Expand Up @@ -177,5 +178,5 @@ func (dm *DeleteRequestHandler) CancelDeleteRequestHandler(w http.ResponseWriter
return
}

w.WriteHeader(http.StatusOK)
w.WriteHeader(http.StatusNoContent)
}

0 comments on commit f5961e6

Please sign in to comment.