Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Stringer of the byte label operator. #2946

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

cyriltovena
Copy link
Contributor

This would cause the operator to become a numeric one once stringified.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This would cause the operator to become a numeric one once stringified.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
pkg/logql/log/label_filter.go Show resolved Hide resolved
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 4da505b into grafana:master Nov 19, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* integration test for deletion of series

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* update changelog

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* Reuse existing timeout

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Removed Println()

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Assert on Purger metrics too

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Removed time.Sleep() from delete series integration test

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Moved CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants