Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue when some samples have replicates and some don't #166

Merged
merged 2 commits into from
Sep 9, 2021
Merged

fix issue when some samples have replicates and some don't #166

merged 2 commits into from
Sep 9, 2021

Conversation

bethac07
Copy link
Member

@bethac07 bethac07 commented Sep 7, 2021

Description

Resolves #165

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@bethac07 bethac07 mentioned this pull request Sep 7, 2021
Closed
niranjchandrasekaran
niranjchandrasekaran approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@niranjchandrasekaran niranjchandrasekaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niranjchandrasekaran niranjchandrasekaran merged commit 189f31d into master Sep 9, 2021
@niranjchandrasekaran niranjchandrasekaran deleted the issues/165 branch September 9, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjchandrasekaran niranjchandrasekaran niranjchandrasekaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modz function giving an unknown error
2 participants
@bethac07 @niranjchandrasekaran