-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action to publish to pypi #188
Conversation
My version of the .github/workflows/publish-to-pypi.yml file has an ending newline, which I added from comments from #187. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
uses: pypa/gh-action-pypi-publish@master | ||
with: | ||
password: ${{ secrets.TEST_PYPI_API_TOKEN }} | ||
repository_url: https://test.pypi.org/legacy/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this point to the pycytominer url? What is legacy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repository_url
is the API endpoint for the test PyPI system. By default that URL points to production PyPI.
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 50 50
Lines 2403 2403
=======================================
Hits 2356 2356
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
p.s. @niranjchandrasekaran - I am not sure why both of us aren't automatically assigned to review. We're both listed as CODEOWNERS. I wonder if we should disable this feature though - do you find it useful being tagged? |
Not sure but it seems like it always assigns me.
We could disable it as long as we are keeping track of PRs and determine who is going to review it. |
Description
As discussed in discussion item #181:
This adds a GitHub action file to build and publish a source (bdist) and binary (wheel) distribution to PyPI.
On any release, the action will build and publish to the test PyPI repo.
On any tagged release the artifacts will be published to the production PyPI repo.
The /dist directory is added to the .gitignore file.
A prior PR (#187) was submitted, but the changes were too broad.
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.