Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codeowners and update install instructions #190

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Feb 9, 2022

Description

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

Codecov Report

Merging #190 (81aefb0) into master (ea3340c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          50       50           
  Lines        2403     2403           
=======================================
  Hits         2356     2356           
  Misses         47       47           
Flag Coverage Δ
unittests 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3340c...81aefb0. Read the comment docs.

@gwaybio
Copy link
Member Author

gwaybio commented Feb 10, 2022

both install methods now work :)

@gwaybio gwaybio merged commit b2510d1 into cytomining:master Feb 10, 2022
@gwaybio gwaybio deleted the doc-update branch February 10, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants