Github actions pre-commit CI pipeline #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 57 57
Lines 3046 3046
=======================================
Hits 2894 2894
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@d33bs Would you be willing to review this PR as it comes from a feature you suggested? |
d33bs
reviewed
May 15, 2023
There was a problem hiding this comment.
Thanks for tagging me for review @kenibrewer and nice work! I had a few comments for your consideration. Please let me know if you have any questions.
13 tasks
13 tasks
gwaybio
added a commit
to gwaybio/pycytominer
that referenced
this pull request
Jun 11, 2023
d33bs
approved these changes
Jun 11, 2023
gwaybio
added a commit
that referenced
this pull request
Jun 11, 2023
…rt (#287) * require greater than python3.8 * remove 3.7, add 3.10 and 3.11 to github actions * close #259 * fix 3.10 version parsing in action actions/runner#1989 * bump read the docs python version * update python versions in dev * bump precommit version * #279 (comment)
|
@gwaybio Could I get this PR merged now that it's ready? |
gwaybio
approved these changes
Jun 11, 2023
This was referenced Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request implements #276 and will automatically run pre-commit checks on any changed files that differ between the target branch and the source branch.
Tests:
Example of a workflow that fails prettier linting checks: https://github.com/kenibrewer/pycytominer/actions/runs/4899077996
Example of a workflow that succeeds after code has been properly formatted: https://github.com/kenibrewer/pycytominer/actions/runs/4899097364
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.