Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syn dependency to 2.0 #29

Closed
d-e-s-o opened this issue Jul 2, 2023 · 4 comments
Closed

Update syn dependency to 2.0 #29

d-e-s-o opened this issue Jul 2, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@d-e-s-o
Copy link
Owner

d-e-s-o commented Jul 2, 2023

We should update the syn dependency to 2.0 now that it has been released.
@d-e-s-o d-e-s-o added the help wanted Extra attention is needed label Jul 2, 2023
tamird added a commit to tamird/test-log that referenced this issue Oct 5, 2023
@tamird
Update syn to 2.0
643a2a4 
Closes d-e-s-o#29.
@tamird
Copy link
Contributor

tamird commented Oct 5, 2023

This was trivial after the simplification in #30, so I added a commit to do that.

tamird added a commit to tamird/test-log that referenced this issue Oct 5, 2023
@tamird
Update syn to 2.0
397fb5e 
Closes d-e-s-o#29.
tamird added a commit to tamird/test-log that referenced this issue Oct 5, 2023
@tamird
Update syn to 2.0
25b2eb8 
Closes d-e-s-o#29.
tamird added a commit to tamird/test-log that referenced this issue Oct 5, 2023
@tamird
Update syn to 2.0
628b7b7 
Remove unused features.

Closes d-e-s-o#29.
@tamird
Copy link
Contributor

tamird commented Oct 5, 2023

Scratch that - syn 2.0 requires edition 2021 so MSRV would have to move up.

@d-e-s-o
Copy link
Owner Author

d-e-s-o commented Oct 8, 2023

Scratch that - syn 2.0 requires edition 2021 so MSRV would have to move up.

Ah okay, that sucks. Thanks for checking.

@tamird
Copy link
Contributor

tamird commented Oct 9, 2023

I think bumping MSRV for this is worth doing. At present this causes anyone who uses test-log to compile syn twice.

tamird added a commit to tamird/test-log that referenced this issue Oct 11, 2023
@tamird
Bump MSRV to 1.56
d47eaf6 
This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes d-e-s-o#29.
@tamird tamird mentioned this issue Oct 11, 2023
Closed
tamird added a commit to tamird/test-log that referenced this issue Oct 11, 2023
@tamird
Bump MSRV to 1.56
16f680f 
This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes d-e-s-o#29.
tamird added a commit to tamird/test-log that referenced this issue Oct 11, 2023
@tamird
Bump MSRV to 1.56
aaf4668 
This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes d-e-s-o#29.
tamird added a commit to tamird/test-log that referenced this issue Oct 11, 2023
@tamird
Bump MSRV to 1.56
cc7f60e 
This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes d-e-s-o#29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump MSRV to 1.56 tamird/test-log
2 participants
@tamird @d-e-s-o