Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.56 #32

Closed
wants to merge 1 commit into from
Closed

Bump MSRV to 1.56 #32

wants to merge 1 commit into from

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Oct 11, 2023

This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes #29.

@tamird
Copy link
Contributor Author

tamird commented Oct 11, 2023

@d-e-s-o this would have the benefit of not requiring dependents to compile syn twice.

@d-e-s-o
Copy link
Owner

d-e-s-o commented Oct 11, 2023

Yes, makes sense. 1.56 should be low enough to not cause problems at this point, despite the crate not having a formal minimum supported Rust version policy. I just pushed another change that causes a conflict with yours. Can you please rebase and fix CI failures?

@tamird tamird force-pushed the msrv branch 2 times, most recently from 16f680f to aaf4668 Compare October 11, 2023 15:45
@tamird
Bump MSRV to 1.56
cc7f60e 
This is the minimum version supported by syn 2.0 because it uses edition
2021 (earlier versions of cargo do not know about edition 2021).

Add rust-version to Cargo.toml which is also supported since 1.56.

Closes d-e-s-o#29.
@tamird
Copy link
Contributor Author

tamird commented Oct 11, 2023

This is green!

d-e-s-o
d-e-s-o approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@d-e-s-o d-e-s-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@d-e-s-o
Copy link
Owner

d-e-s-o commented Oct 12, 2023

I merged the patch with one small change. Thanks again! Let me know if you have other changes planned, or I'll cut a new relase in the coming days.

@d-e-s-o d-e-s-o closed this Oct 12, 2023
@tamird tamird deleted the msrv branch October 12, 2023 17:25
@tamird
Copy link
Contributor Author

tamird commented Oct 12, 2023

Thanks! Nothing further planned.

@tamird
Copy link
Contributor Author

tamird commented Oct 12, 2023

Ah, one other thought: we could improve the ergonomics of using the macro by extracting a test-log-runtime crate and making it a dependency of test-log, then we could reexport env_logger and tracing_subscriber from the runtime crate (using the same optional features of the test-log crate). That would remove the need for users to manually include these dependencies (the last paragraph of this section of the README).

@d-e-s-o
Copy link
Owner

d-e-s-o commented Oct 12, 2023

Yeah, that has been discussed previously. It's definitely a possibility and has been on my TODO list's backlogged part for a while. If you have the cycles, feel free to go ahead.

@d-e-s-o
Copy link
Owner

d-e-s-o commented Oct 13, 2023

I think it's fine to cut another release should we introduce an additional crate into the mix, so I went ahead and cut 0.2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-e-s-o d-e-s-o d-e-s-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update syn dependency to 2.0
2 participants
@tamird @d-e-s-o