Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipped Voronoi cells sometimes have zero-length edges. #42

Closed
mbostock opened this issue May 23, 2018 · 3 comments · Fixed by #81
Closed

Clipped Voronoi cells sometimes have zero-length edges. #42

mbostock opened this issue May 23, 2018 · 3 comments · Fixed by #81
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

Not sure if this is a bug per se, but it would be nice to avoid them.
mbostock added a commit that referenced this issue May 23, 2018
@mbostock
Don’t repeat corners. Related #42.
063adee
@mourner mourner added the enhancement New feature or request label Jun 19, 2018
@mourner
Copy link
Collaborator

mourner commented Jun 20, 2019

Is there an example of this?

@Fil
Copy link
Member

Fil commented Jun 22, 2019 •
edited
Loading

image

https://observablehq.com/d/93c4555b681dcf86

@Fil
Copy link
Member

Fil commented Jul 23, 2019

testing for (points[i] !== points[i-2] || points[i+1] !== points[i-1]) in https://github.com/d3/d3-delaunay/blob/master/src/voronoi.js#L103 does the trick; but I don't know the price in terms of speed (possibly negligible?).

Fil added a commit that referenced this issue Jul 23, 2019
@Fil
remove zero-length edges from clipped voronoi cells
4c2a05f 
fixes #42 ; see https://observablehq.com/d/93c4555b681dcf86 for an example
@Fil Fil mentioned this issue Jul 23, 2019
Merged
@Fil Fil closed this as completed in #81 Jul 23, 2019
Fil added a commit that referenced this issue Jul 23, 2019
@Fil
remove zero-length edges from clipped voronoi cells
6cde401 
fixes #42 ; see https://observablehq.com/d/93c4555b681dcf86 for an example
@mbostock mbostock mentioned this issue Aug 22, 2019
Closed
@mbostock mbostock mentioned this issue Sep 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove zero-length edges from clipped voronoi cells d3/d3-delaunay
3 participants
@Fil @mourner @mbostock