Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove zero-length edges from clipped voronoi cells #81

Merged
merged 1 commit into from
Jul 23, 2019
Merged

remove zero-length edges from clipped voronoi cells #81

merged 1 commit into from
Jul 23, 2019

Conversation

Fil
Copy link
Member

@Fil Fil commented Jul 23, 2019

@Fil Fil requested a review from mbostock July 23, 2019 07:55
@Fil
Copy link
Member Author

Fil commented Jul 23, 2019

Should we investigate the time cost?

mourner
mourner approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we investigate the time cost?

Nah, it's negligible.

@Fil Fil merged commit 6cde401 into master Jul 23, 2019
@Fil Fil deleted the issue42 branch July 23, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipped Voronoi cells sometimes have zero-length edges.
2 participants
@Fil @mourner