DafnyLanguageServer NuGet package broken because DafnyServer isn't published #2776
Comments
robin-aws
added
release-blocker
|
I suspect this isn't a problem with |
|
Correction, I was thrown off by the fact that I added the release note about the PR that introduced The only reasonable fix seems to be ensuring that all dependencies of each Nuget-published package are also Nuget-published! |
|
The root cause for why |
Fixes #2776: the root cause is that `DafnyLanguageServer` depends on `DafnyServer`, but the latter was never published. Also publishes the new `DafnyDriver` and `DafnyCore` packages I extracted out earlier, as otherwise the same problem would affect more packages on the next release. Also replaces `version.cs` with the more automatic mechanism of a `Build.Directory.props` file, just as Boogie uses. The side effect is that the version is more consistently aligned across all the published packages. In particular it changes the current `DafnyRuntime` version from `1.2.0` to `3.8.1.40901` (or rather `3.9.0` by the time we release this). I managed to augment the existing GHA that verifies the `dafny` dotnet tool to also do a very superficial verification that each library we publish can at least resolve all of its dependencies through NuGet.
See https://www.nuget.org/packages/DafnyLanguageServer: clicking on the DafnyServer link under Dependencies leads to a 404, and similarly a test project that depends on DafnyLanguageServer fails to restore for the same reason.
I'm not yet sure why this isn't an issue with DafnyPipeline depending on DafnyCore, which also isn't published. It seems like the packaging process just inlined DafnyCore there instead.
We also need a mechanism similar to
release-downloads-nuget.ymlthat attempts to use the other packages we are publishing, to catch issues like this ideally during the nightly build, or at the very least immediately after releasing.The text was updated successfully, but these errors were encountered: