Publish DafnyServer/Driver/Core to NuGet as well #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace version.cs with Directory.Build.props while we’re at it.
atomb
requested changes
Sep 22, 2022
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| library-name: [ DafnyPipeline, DafnyLanguageServer, DafnyRuntime, DafnyCore, DafnyDriver ] |
There was a problem hiding this comment.
Should this include DafnyServer?
Not that we have to do it as part of this PR, but it would be great if there were a way to automatically populate this list.
There was a problem hiding this comment.
Yup, definitely, will add.
I made an attempt at automatically populating this, but it's a bit non-trivial since dotnet install Dafny never works, as it complains that you're supposed to dotnet tool install that instead, so I'd at least need to special-case that package. Added a comment to that effect too.
atomb
approved these changes
Sep 23, 2022
Closed
MikaelMayer
reviewed
Oct 3, 2022
| match = re.search(r'\[assembly:\s+AssemblyVersion\("([0-9]+.[0-9]+.[0-9]+).([0-9]+)"\)\]', fp.read()) | ||
| # Checking Directory.Build.props | ||
| with open(path.join(SOURCE_DIRECTORY, "Directory.Build.props")) as fp: | ||
| match = re.search(r'\<VersionPrefix\>([0-9]+.[0-9]+.[0-9]+).([0-9]+)"\)', fp.read()) |
There was a problem hiding this comment.
@cpitclaudel is going to repair this broken regex :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2776: the root cause is that
DafnyLanguageServerdepends onDafnyServer, but the latter was never published. Also publishes the newDafnyDriverandDafnyCorepackages I extracted out earlier, as otherwise the same problem would affect more packages on the next release.Also replaces
version.cswith the more automatic mechanism of aBuild.Directory.propsfile, just as Boogie uses. The side effect is that the version is more consistently aligned across all the published packages. In particular it changes the currentDafnyRuntimeversion from1.2.0to3.8.1.40901(or rather3.9.0by the time we release this).I managed to augment the existing GHA that verifies the
dafnydotnet tool to also do a very superficial verification that each library we publish can at least resolve all of its dependencies through NuGet.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.