Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard' #22985

Closed
alangenfeld opened this issue Jul 12, 2024 · 5 comments · Fixed by #22986
Closed

ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard' #22985

alangenfeld opened this issue Jul 12, 2024 · 5 comments · Fixed by #22986

Comments

@alangenfeld
Copy link
Member

alangenfeld commented Jul 12, 2024 •
edited
Loading

This failure occurs on python 3.12.4 and we missed it since we test on a lower version of 3.12
@alangenfeld alangenfeld mentioned this issue Jul 12, 2024
Closed
@cbini
Copy link
Contributor

cbini commented Jul 12, 2024

thanks @alangenfeld is there a workaround for this too?

@tenhaus
Copy link

tenhaus commented Jul 12, 2024

thanks @alangenfeld is there a workaround for this too?

It's ok in 3.12.3. I'm sure they'll get it updated soon. dagster team seems super active.

@alangenfeld
Copy link
Member Author

pin dagster back to 1.7.12 for now, fix will be included in the next release

@alangenfeld
Copy link
Member Author

(or use python 3.12.3 i guess but I assume pinning dagster is easier)

@alangenfeld alangenfeld mentioned this issue Jul 12, 2024
Merged
@cbini
Copy link
Contributor

cbini commented Jul 12, 2024 •
edited
Loading

it's simple enough to pin the python version on my Dockerfile, gonna confirm that solves it on my end as well.

UPDATE: yeah we're good on 3.12.3

alangenfeld added a commit that referenced this issue Jul 12, 2024
@alangenfeld
[check builder] 3.12.4 fix (#22986)
b3e0cd4 
`recursive_guard` got made keyword arg only in
python/cpython#118009 which released in `3.12.4`
(we run an older version in buildkite so we missed it)

fixes #22985

## How I Tested These Changes

on a fresh 3.12.4 venv
`pytest
python_modules/dagster/dagster_tests/general_tests/test_record.py
python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.py`
which was failing before fix
@jdangerx jdangerx mentioned this issue Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[check builder] 3.12.4 fix dagster-io/dagster
3 participants
@alangenfeld @tenhaus @cbini