Integrate with TanStack Router

[dai-shi]

Waku's minimal API is designed to be router agnostic.
It would be nice if integration with TanStack Router is possible.
Would anyone like to give a challenge? First, investigate the feasibility.

[dai-shi]

backlink: https://twitter.com/tannerlinsley/status/1735432759768658119

[Aslemammad]

I'd like to take this.

[dai-shi]

Looking forward to it!

My first trial was #118, but it's too rough.

[ojj1123]

@dai-shi

Waku's minimal API is designed to be router agnostic.

Why is it intended to be router-agnostic?
Could I understand as the intend using just a various of router solution's features(such as loader, cache, etc) w/o implementing this features on Waku?

[dai-shi]

Waku started as an experimental project, and while we now focus on making it a production-level RSC framework, we want others to experiment RSC and come up with new solutions. So, the minimal API is for such library authors.

We'll providing an official router waku/router. #293
It's built on top of the minimal API. So, Waku's core doesn't have router features.

[LizAinslie]

I have been hacking at this for a little bit now and i've managed to put together a small sample of Waku + Tanstack Router on the latest versions of each here: https://github.com/LizAinslie/waku-tanstack-poc

It works in dev mode, however there are some really obscure errors produced when building and starting for production

[dai-shi]

I'm thinking about changing our minimal api for a following release. So, it would be nice to learn from tanstack router integration. Taking a closer look. 👀

[dai-shi]

So, while I'm not sure if I understand every details, it looks to me that TSR is a client library for SPA (optionally with multi-page SSR), so the integration with Waku mostly means as a SPA.
The benefit of using Waku with TSR will be server actions, and possibly rsc-based data fetching (which is still to be explored.)

What concerns me is TSR now pushes file-based routing https://tanstack.com/router/latest/docs/framework/react/guide/file-based-routing, which generally conflicts with Waku's fs router. The TSR's config-based router should be feasible to integrate with Waku, but I wonder if it's appealing to TSR users.

[tylersayshi]

@dai-shi What features would you like to get from TSR and which would you like to leave out?

It feels like from reading above that TSR is a bit too opinionated to fit fully in a waku project, but some of the features could be really helpful.

I really like the Link's and typescript support for routes that TSR has implemented and I'd imagine something like that could just be a feature that waku/router replicates (I'd be happy to help with adding something like that).

[dai-shi]

My motivation is to prove that Waku core is router agnostic.
I agree TSR is too opinionated to fit well with Waku.

typescript support for routes

Yeah, they are nice.

(I'd be happy to help with adding something like that)

Yeah, that would be helpful. Feel free to work on it. One note is that I'm planning to redesign the minimal api defineEntries and router integration, and especially around buildData and skipList. So, we shouldn't change the core part yet. If the modification is in the higher level, it should be fine.

[Aslemammad]

That's amazing, I'd like to use this as an inspiration! Do you have discord?

…

On Fri, 5 Jan 2024, 09:32 Liz Ainslie, ***@***.***> wrote: I have been hacking at this for a little bit now and i've managed to put together a small sample of Waku + Tanstack Router on the latest versions of each here: https://github.com/LizAinslie/waku-tanstack-poc It works in dev mode, however there are some really obscure errors produced when building and starting for production — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJBMICCFZBSNGKFW3APJTDLYM6JQJAVCNFSM6AAAAABAVX5SAGVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DAMJZHA4DI> . You are receiving this because you commented.Message ID: ***@***.***>