-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Vite and update dependencies #136
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8c027c:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the beat solution is waiting for upstream give a patch version. Since waku is a library, we cannot control let user to install the patch automatically.
"busboy": "^1.6.0", | ||
"vite": "^4.4.9" | ||
"vite": "4.4.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, doesn't vite
should be in the peer dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need it in the peer deps as it's already in the deps.
Thanks.
We waited for several months and it seems to take more time.
I would actually like to establish the patch solution with libraries. So, happy to learn the cases where the patch isn't applied automatically. For now, pnpm is challenging and if users don't use |
@Tobbe said they also patched it: vitejs/vite#13487 (comment) And, I just found vitejs/vite#14498 |
Let's merge this and wait a new release from Vite. |
Test with:
Close #96
Close #111
Close #114