Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Vite and update dependencies #136

Merged
merged 17 commits into from
Oct 8, 2023
Merged

Patch Vite and update dependencies #136

merged 17 commits into from
Oct 8, 2023

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Oct 6, 2023

⚠️ This would only work on Linux and MacOS for now.

Test with:

  • npm
  • yarn1
  • pnpm -> will test after releasing

Close #96
Close #111
Close #114

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 1:06am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8c027c:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the beat solution is waiting for upstream give a patch version. Since waku is a library, we cannot control let user to install the patch automatically.

"busboy": "^1.6.0",
"vite": "^4.4.9"
"vite": "4.4.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, doesn't vite should be in the peer dependencies?

Copy link
Owner Author

@dai-shi dai-shi Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it in the peer deps as it's already in the deps.

@dai-shi
Copy link
Owner Author

dai-shi commented Oct 6, 2023

Thanks.

I think the beat solution is waiting for upstream give a patch version.

We waited for several months and it seems to take more time.
This has stopped us developing/testing things. Rather than stopping, we should move forward.

Since waku is a library, we cannot control let user to install the patch automatically.

I would actually like to establish the patch solution with libraries. So, happy to learn the cases where the patch isn't applied automatically. For now, pnpm is challenging and if users don't use create-waku it fails. I wonder if there's a better idea.

@dai-shi
Copy link
Owner Author

dai-shi commented Oct 7, 2023

@Tobbe said they also patched it: vitejs/vite#13487 (comment)

And, I just found vitejs/vite#14498

@dai-shi
Copy link
Owner Author

dai-shi commented Oct 8, 2023

Let's merge this and wait a new release from Vite.

@dai-shi dai-shi merged commit 81eddc9 into main Oct 8, 2023
5 checks passed
@dai-shi dai-shi deleted the update-deps branch October 8, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hooks cannot be used in server component Error with latest react builds build error in SWR 2.2.0
2 participants