refactor: use tsconfig monorepo #132

himself65 · 2023-09-19T20:07:57Z

Add top-level ts config that includes all submodules, which restricts the type and isolated type context. If some files are missing or wrong-typed, it will throw the error.

vercel · 2023-09-19T20:08:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 11:17pm

codesandbox-ci · 2023-09-19T20:08:21Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf3e9da:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration
React	Configuration
React TypeScript	Configuration

packages/waku/src/types.d.ts

packages/waku/src/config.ts

packages/create-waku/src/cli.ts

.github/workflows/cd.yml

dai-shi

I'm sorry, I had pending comments that I thought I submitted, but it's actually not.

tsconfig.json

examples/01_counter/tsconfig.json

dai-shi · 2023-10-06T01:18:08Z

Please make changes minimal as I'm working on #136 too.

himself65 · 2023-10-23T21:58:34Z

I will continue work on this today

dai-shi

This looks very nice.
I haven't used "references" before.
My preference is to have things as minimal as possible.
Some of tsconfig properties are new to me, and I can't judge, but please keep that in mind.

dai-shi · 2023-10-24T00:26:03Z

.github/workflows/ci.yml

@@ -20,6 +20,21 @@ jobs:
      - run: pnpm install --frozen-lockfile
      - run: pnpm test

+  type-check:


We run tsc in pnpm test, so it's not necessary here?

dai-shi · 2023-10-24T00:27:19Z

examples/01_counter/tsconfig.json

+    "outDir": "./dist",
+    "rootDir": "./src"


Not sure why they are required, but maybe they are?

it is required otherwise the output file structure will be

- dist - src - xxx.js

instead of

- dist - xxx.js

It's not needed here since waku build is real output files. But just some habit for me.

But it's necessary for packages/waku since we're monorepo tsconfig now

hm, that makes sense.

dai-shi · 2023-10-24T00:28:57Z

examples/02_async/tsconfig.json

+    {
+      "path": "./tsconfig.node.json"
+    }
+  ]


Why do we need this in 02_async, not in 01_counter?
I do not understand why two tsconfig files are required, instead of one.

because vite.config.ts is actually in a different environment with files in ./src.

For example, you cannot include src files in config because of two ts configs with different files included

This is good for mono repo because sometimes you will mistakenly include files across the packages

Also it will be compiled to the different outputDir based on tsconfig.

01_counter doesn't have two configs because there is no vite.config.ts

Thanks for the explanation. We will revisit this later.

packages/create-waku/tsconfig.json

packages/waku/src/types.d.ts

packages/waku/tsconfig.json

tsconfig.json

himself65 · 2023-10-24T01:00:44Z

You can read the document here: https://www.typescriptlang.org/docs/handbook/project-references.html

dai-shi

Looking good. I feel like I need to learn some more later.

dai-shi · 2023-10-24T10:42:26Z

examples/02_async/tsconfig.json

+      // React Server Async Component type
+      "react/experimental"


Can we put this also in the source code as inline comment? Just a preference, but it looks more explicit.

This is remaining. Also in 10_dynamicroute.

packages/waku/src/types.d.ts

dai-shi · 2023-10-24T10:47:41Z

packages/create-waku/tsconfig.json

+    "module": "ESNext",
+    "moduleResolution": "bundler",


I don't think this is correct for cli tools. I think it should be nodenext, no?

bundler is better? Since you are using esbuild here

https://www.typescriptlang.org/tsconfig#moduleResolution

For now i think change it to nodenext wont affect anything

Oh, I forgot that we use esbuild in cli. Yeah, let's use nodenext if we can. Using esbuild is only a temporary solution anyway.

Oh I see a error and its seems correct

In this case, create-waku is cjs module but we import a ESM module, I'm not sure the purpose of you're importing this

importing fs-extra/esm ?
@vasucp1207 introduced it.
Maybe we should refactor it. My intention is everything should be ESM and no CJS in this repo. (and our plan was to avoid esbuild eventually.)

I see, i can do that but it's too far away from this PR

That would be great. Feel free to open a new PR.

dai-shi

we are almost there.

dai-shi · 2023-10-24T22:39:22Z

examples/02_async/tsconfig.json

+      // React Server Async Component type
+      "react/experimental"


This is remaining. Also in 10_dynamicroute.

package.json

dai-shi

LGTM
Thanks for your contribution!

vercel bot deployed to Preview September 19, 2023 20:08 View deployment

vercel bot deployed to Preview September 19, 2023 20:10 View deployment

vercel bot deployed to Preview September 19, 2023 20:11 View deployment

himself65 commented Sep 19, 2023

View reviewed changes

packages/waku/src/types.d.ts Show resolved Hide resolved

packages/waku/src/config.ts Outdated Show resolved Hide resolved

packages/create-waku/src/cli.ts Show resolved Hide resolved

himself65 commented Sep 19, 2023

View reviewed changes

.github/workflows/cd.yml Outdated Show resolved Hide resolved

dai-shi requested changes Oct 3, 2023

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

examples/01_counter/tsconfig.json Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview October 5, 2023 15:36 Failure

himself65 force-pushed the himself65/ts-monorepo branch from a34f586 to 02190fa Compare October 5, 2023 15:36

vercel bot had a problem deploying to Preview October 23, 2023 22:37 Failure

himself65 force-pushed the himself65/ts-monorepo branch from 7a8d301 to 6b96508 Compare October 23, 2023 23:03

vercel bot deployed to Preview October 23, 2023 23:04 View deployment

vercel bot deployed to Preview October 23, 2023 23:07 View deployment

himself65 requested a review from dai-shi October 23, 2023 23:42

himself65 added 2 commits October 23, 2023 19:10

refactor: use ts monorepo

17a4761

fix: lint

5ee1aed

himself65 force-pushed the himself65/ts-monorepo branch from f078b1d to 5ee1aed Compare October 24, 2023 00:10

vercel bot deployed to Preview October 24, 2023 00:11 View deployment

dai-shi reviewed Oct 24, 2023

View reviewed changes

fix: tsconfig stuff

daa351e

vercel bot deployed to Preview October 24, 2023 00:58 View deployment

fix: ci config to run monorepo type check

5b0f39d

vercel bot deployed to Preview October 24, 2023 01:01 View deployment

fix: update tsconfig

c1e91ce

vercel bot deployed to Preview October 24, 2023 01:30 View deployment

fix: update tsconfig

46f667c

vercel bot deployed to Preview October 24, 2023 01:36 View deployment

dai-shi reviewed Oct 24, 2023

View reviewed changes

Merge branch 'main' into himself65/ts-monorepo

4b11696

vercel bot deployed to Preview October 24, 2023 10:50 View deployment

vercel bot deployed to Preview October 24, 2023 21:00 View deployment

himself65 force-pushed the himself65/ts-monorepo branch from 5cde695 to 147c547 Compare October 24, 2023 21:00

vercel bot deployed to Preview October 24, 2023 21:01 View deployment

fix: resolve moduleResolution

4193584

himself65 force-pushed the himself65/ts-monorepo branch from 147c547 to 4193584 Compare October 24, 2023 21:02

vercel bot deployed to Preview October 24, 2023 21:02 View deployment

dai-shi reviewed Oct 24, 2023

View reviewed changes

himself65 added 2 commits October 24, 2023 18:13

fix: update package.json

0e43f84

fix: update tsconfig.json

bf3e9da

vercel bot deployed to Preview October 24, 2023 23:17 View deployment

dai-shi approved these changes Oct 25, 2023

View reviewed changes

dai-shi merged commit 39aadeb into dai-shi:main Oct 25, 2023
5 checks passed

himself65 mentioned this pull request Oct 25, 2023

refactor: remove esbuild #144

Merged

himself65 deleted the himself65/ts-monorepo branch October 25, 2023 02:15

genffy mentioned this pull request Oct 28, 2023

refactor use tsconfig monorepo madaotech/ann#1

Open

himself65 mentioned this pull request Jan 12, 2024

fix: cover type check on all ts files run-llama/LlamaIndexTS#372

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use tsconfig monorepo #132

refactor: use tsconfig monorepo #132

himself65 commented Sep 19, 2023 •

edited

Loading

vercel bot commented Sep 19, 2023 •

edited

Loading

codesandbox-ci bot commented Sep 19, 2023 •

edited

Loading

dai-shi left a comment

dai-shi commented Oct 6, 2023

himself65 commented Oct 23, 2023

dai-shi left a comment

dai-shi Oct 24, 2023

dai-shi Oct 24, 2023

himself65 Oct 24, 2023

dai-shi Oct 24, 2023

dai-shi Oct 24, 2023

himself65 Oct 24, 2023 •

edited

Loading

dai-shi Oct 24, 2023

himself65 commented Oct 24, 2023

dai-shi left a comment

dai-shi Oct 24, 2023

dai-shi Oct 24, 2023

dai-shi Oct 24, 2023

himself65 Oct 24, 2023

himself65 Oct 24, 2023

dai-shi Oct 24, 2023

himself65 Oct 24, 2023

himself65 Oct 24, 2023

dai-shi Oct 24, 2023

himself65 Oct 24, 2023

dai-shi Oct 25, 2023

dai-shi left a comment

dai-shi Oct 24, 2023

dai-shi left a comment

refactor: use tsconfig monorepo #132

refactor: use tsconfig monorepo #132

Conversation

himself65 commented Sep 19, 2023 • edited Loading

vercel bot commented Sep 19, 2023 • edited Loading

codesandbox-ci bot commented Sep 19, 2023 • edited Loading

dai-shi left a comment

Choose a reason for hiding this comment

dai-shi commented Oct 6, 2023

himself65 commented Oct 23, 2023

dai-shi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himself65 Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himself65 commented Oct 24, 2023

dai-shi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dai-shi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dai-shi left a comment

Choose a reason for hiding this comment

himself65 commented Sep 19, 2023 •

edited

Loading

vercel bot commented Sep 19, 2023 •

edited

Loading

codesandbox-ci bot commented Sep 19, 2023 •

edited

Loading

himself65 Oct 24, 2023 •

edited

Loading