-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setuptools warning #411
Comments
What command do you run to get these warnings? |
Based on https://setuptools.pypa.io/en/latest/userguide/datafiles.html it's not clear to me what would be missing in our setup. |
the warning comes from portage that search for 'setuptools warning' string: The exact command used to build is:
For completeness I'm attaching the full build log: An interesting part is:
|
I can reproduce indeed; thank you.
Will look at it.
|
This reverts commit 8a5fa22, which was introduced as a workaround for an issue RPM build system: rpm-software-management/rpm#2532 but now poses problems with recent setuptools versions that warn about missing packages: #411 Now that the RPM issue got resolved, it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages.
This reverts commit 8a5fa22, which was introduced as a workaround for an issue RPM build system: rpm-software-management/rpm#2532 but now poses problems with recent setuptools versions that warn about missing packages: #411 Now that the RPM issue got resolved, it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages.
This reverts commit 8a5fa22, which was introduced as a workaround for an issue RPM build system (rpm-software-management/rpm#2532) but now poses problems with recent setuptools versions that warn about missing packages: #411 Now that the RPM issue got resolved, it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages.
This reverts commit 8a5fa22, which was introduced as a workaround for an issue RPM build system (rpm-software-management/rpm#2532) but now poses problems with recent setuptools versions that warn about missing packages: #411 Now that the RPM issue got resolved, it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages.
Automatic package discovery by setuptools was disabled in commit 8a5fa22, somehow as a workaround for an issue RPM build system (rpm-software-management/rpm#2532) or maybe because it was misconfigured then. However, having to declare packages explicitly (options 'packages' in '[tool.setuptools]' section of pyproject.toml) is tedious and error-prone as shown in #411 which indicates that we were missing some sub-packages. In the meantime, the RPM issue got resolved, so it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages. So we get back to automatic discovery here, although not using [tool.setuptools.packages.find], but simply letting setuptools discover the "flat-layout" we're using, as can be seen by the following messages from 'python -m build' un: * Building sdist... No `packages` or `py_modules` configuration, performing automatic discovery. `flat-layout` detected -- analysing . discovered packages -- ['pgactivity', 'pgactivity.profiles', 'pgactivity.queries'] This requires no configuration as we use common excluded names (like 'tests', 'docs').
Automatic package discovery by setuptools was disabled in commit 8a5fa22, somehow as a workaround for an issue RPM build system (rpm-software-management/rpm#2532) or maybe because it was misconfigured then. However, having to declare packages explicitly (options 'packages' in '[tool.setuptools]' section of pyproject.toml) is tedious and error-prone as shown in #411 which indicates that we were missing some sub-packages. In the meantime, the RPM issue got resolved, so it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages. So we get back to automatic discovery here, although not using [tool.setuptools.packages.find], but simply letting setuptools discover the "flat-layout" we're using, as can be seen by the following messages from 'python -m build' un: * Building sdist... No `packages` or `py_modules` configuration, performing automatic discovery. `flat-layout` detected -- analysing . discovered packages -- ['pgactivity', 'pgactivity.profiles', 'pgactivity.queries'] This requires no configuration as we use common excluded names (like 'tests', 'docs').
Just released version 3.5.1 with this and #410 fixed. |
By packaging 3.5.0 on Gentoo Linux I see the following setuptools warning:
The text was updated successfully, but these errors were encountered: