Enable back setuptools automatic discovery #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patched pyproject.toml on top of 3.5.0 and fails with: Environment info: |
|
It works for me, but it introduces another problem and the package manager denies to install the package: I think it is self-explain, but if you have doubts please let me know. |
|
Thank you both for testing. |
this works for me. No further errors |
|
works for me also. |
Automatic package discovery by setuptools was disabled in commit 8a5fa22, somehow as a workaround for an issue RPM build system (rpm-software-management/rpm#2532) or maybe because it was misconfigured then. However, having to declare packages explicitly (options 'packages' in '[tool.setuptools]' section of pyproject.toml) is tedious and error-prone as shown in #411 which indicates that we were missing some sub-packages. In the meantime, the RPM issue got resolved, so it seems safe to get back to automatic discovery as this resolves the later issue in a more future-proof way than explicitly listing packages. So we get back to automatic discovery here, although not using [tool.setuptools.packages.find], but simply letting setuptools discover the "flat-layout" we're using, as can be seen by the following messages from 'python -m build' un: * Building sdist... No `packages` or `py_modules` configuration, performing automatic discovery. `flat-layout` detected -- analysing . discovered packages -- ['pgactivity', 'pgactivity.profiles', 'pgactivity.queries'] This requires no configuration as we use common excluded names (like 'tests', 'docs').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #411
@asarubbo, can you check if this resolves #411 on Gentoo?
@mikelolasagasti, can you check if this change works for Fedora, as this reverts the one from #378?