Exclude test and docs from package #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the report; indeed this is problematic, and I can confirm the issue with However, after re-reading setuptools documentation about automatic discovery, I wonder if we shouldn't just remove the diff --git a/pyproject.toml b/pyproject.toml
index c67455f..2fbf803 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -79,9 +79,6 @@ Homepage = "https://github.com/dalibo/pg_activity"
[tool.setuptools.dynamic]
version = { attr = "pgactivity.__version__" }
-[tool.setuptools.packages.find]
-where = ["."]
-
[tool.black]
line-length = 88
include = '\.pyi?$'Can you try if that works for you? |
|
It fails with: |
Where does this |
|
It's created by Fedora's build system: You can check a full log here: |
|
Ok; can you try that? diff --git a/pyproject.toml b/pyproject.toml
index c67455f..5c7fbcc 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -79,8 +79,8 @@ Homepage = "https://github.com/dalibo/pg_activity"
[tool.setuptools.dynamic]
version = { attr = "pgactivity.__version__" }
-[tool.setuptools.packages.find]
-where = ["."]
+[tool.setuptools]
+packages = ["pgactivity"]
[tool.black]
line-length = 88(Last resort attempt; I'd rather be explicit on what to include than listing what should be excluded.) |
|
Fails:
I pushed a new change using include rather than excluding. It works for me. |
The message is about the toml file being invalid because it contains a duplicated |
Sorry, you're right, did not realize about Works fine with your proposal. I updated the PR with that change, but as solution was yours feel free to close this and push a patch in your name. |
Automatic discovery, a.k.a. `packages.find` option, requires some tweak on include/exclude so only required files are installed. Declaring `packages` directly simplifies this by just adding the required package.
|
Just published version 3.4.2 including this change. Thank you. |
I've reported this at rpm-software-management/rpm#2532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the migration to
pyproject.tomldone in 3.4.0, creating the package for Fedora fails with the following error:Those files were not installed before 3.4.0 and are missing the
pgactivitypackage name.Excluding
testsanddocspackage can be built again.