Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowSector #898

Merged
merged 30 commits into from
Jun 24, 2024
Merged

Add WindowSector #898

merged 30 commits into from
Jun 24, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented May 17, 2024

The WindowManager no longer stores or directly interacts with windows. Instead, the window manager now calls pickers and transforms for the WindowSector of the Store.

@dalyIsaac dalyIsaac added enhancement New feature or request refactor The code can be simplified/moved/cleaned up labels May 17, 2024
@dalyIsaac dalyIsaac linked an issue May 17, 2024 that may be closed by this pull request
14 tasks
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 83.24125% with 91 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (3db587c) to head (50ffc11).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Whim/Store/Store.cs 38.88% 30 Missing and 3 partials ⚠️
src/Whim.TestUtils/CaptureWinEventProc.cs 0.00% 32 Missing ⚠️
src/Whim/Window/WindowManager.cs 80.48% 0 Missing and 8 partials ⚠️
src/Whim/Store/WindowSector/WindowSector.cs 86.27% 1 Missing and 6 partials ⚠️
src/Whim.Bar/BarWindow.xaml.cs 0.00% 3 Missing ⚠️
src/Whim/Native/WindowExtensions.cs 0.00% 3 Missing ⚠️
src/Whim/Native/CoreNativeManager.cs 0.00% 1 Missing ⚠️
src/Whim/Native/DeferWindowPosManager.cs 0.00% 0 Missing and 1 partial ⚠️
src/Whim/Store/RootSector/RootEventListener.cs 0.00% 1 Missing ⚠️
...dowSector/Transforms/WindowMoveStartedTransform.cs 94.73% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   80.76%   80.48%   -0.28%     
==========================================
  Files         220      232      +12     
  Lines       10578    10750     +172     
  Branches     1195     1214      +19     
==========================================
+ Hits         8543     8652     +109     
- Misses       1913     1961      +48     
- Partials      122      137      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac added the core Whim label May 19, 2024
@dalyIsaac dalyIsaac force-pushed the 895-windowsector branch 2 times, most recently from deb59c9 to 247393a Compare May 30, 2024 13:19
@dalyIsaac
Copy link
Owner Author

dalyIsaac commented Jun 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dalyIsaac and the rest of your teammates on Graphite Graphite

This was referenced Jun 24, 2024
@dalyIsaac dalyIsaac marked this pull request as ready for review June 24, 2024 05:06
@dalyIsaac dalyIsaac merged commit 34be78d into main Jun 24, 2024
6 of 7 checks passed
@dalyIsaac dalyIsaac deleted the 895-windowsector branch June 24, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowSector
1 participant