Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapSector #901

Merged
merged 44 commits into from
Jun 24, 2024
Merged

Add MapSector #901

merged 44 commits into from
Jun 24, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented May 19, 2024

The Butler no longer stores or directly interacts with the mapping of monitors to workspaces to windows. Instead, the Butler now calls pickers and transforms for the MapSector of the Store.

@dalyIsaac dalyIsaac added enhancement New feature or request refactor The code can be simplified/moved/cleaned up core Whim labels May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 94.10319% with 48 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (34be78d) to head (efb0af8).

Files Patch % Lines
src/Whim/Butler/Butler.cs 72.72% 0 Missing and 12 partials ⚠️
...nitorSector/Transforms/MonitorsChangedTransform.cs 84.74% 7 Missing and 2 partials ⚠️
src/Whim/Butler/ButlerPantry.cs 28.57% 5 Missing ⚠️
...or/Transforms/InitializeFromSavedStateTransform.cs 88.23% 3 Missing and 1 partial ⚠️
...pSector/Transforms/FocusMonitorDesktopTransform.cs 75.00% 2 Missing and 1 partial ⚠️
...Transforms/MoveWindowToAdjacentMonitorTransform.cs 66.66% 2 Missing and 1 partial ⚠️
.../Transforms/MoveWindowEdgesInDirectionTransform.cs 89.28% 2 Missing and 1 partial ⚠️
src/Whim/Context/Context.cs 0.00% 2 Missing ⚠️
src/Whim/Store/MapSector/MapPickers.cs 97.50% 1 Missing and 1 partial ⚠️
src/Whim/Store/MapSector/MapSector.cs 95.83% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   80.48%   80.55%   +0.07%     
==========================================
  Files         232      249      +17     
  Lines       10750    10943     +193     
  Branches     1214     1243      +29     
==========================================
+ Hits         8652     8815     +163     
- Misses       1961     1976      +15     
- Partials      137      152      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac
Copy link
Owner Author

dalyIsaac commented Jun 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dalyIsaac and the rest of your teammates on Graphite Graphite

This was referenced Jun 24, 2024
@dalyIsaac dalyIsaac marked this pull request as ready for review June 24, 2024 05:07
Base automatically changed from 895-windowsector to main June 24, 2024 05:09
@dalyIsaac dalyIsaac linked an issue Jun 24, 2024 that may be closed by this pull request
18 tasks
@dalyIsaac dalyIsaac merged commit 3f8594a into main Jun 24, 2024
6 checks passed
@dalyIsaac dalyIsaac deleted the 900-mapsector branch June 24, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapSector
1 participant