Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border behind PFP #597

Closed
jb55 opened this issue Dec 19, 2024 · 0 comments · Fixed by #681
Closed

Border behind PFP #597

jb55 opened this issue Dec 19, 2024 · 0 comments · Fixed by #681
Assignees
@jb55
Labels
good first issue Good for newcomers ui UI-related issues

Comments

@jb55
Copy link
Contributor

jb55 commented Dec 19, 2024

We just need to render a dark circle behind the profile pic for a border effect.
@jb55 jb55 added good first issue Good for newcomers ui UI-related issues labels Dec 19, 2024
kuba-04 added a commit to kuba-04/notedeck that referenced this issue Jan 28, 2025
@kuba-04
damus-io#597 add border behind pfp
a708177
@kuba-04 kuba-04 mentioned this issue Jan 28, 2025
Merged
@jb55 jb55 self-assigned this Feb 4, 2025
jb55 added a commit that referenced this issue Feb 4, 2025
@jb55
Merge 'add border behind pfp' #597
635c977 
Hello new contributor!

jglad (4):
      #597 add border behind pfp
      replace with full circle border
      make optional
      fix formatting
@jb55 jb55 closed this as completed in #681 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jb55 jb55

Labels
good first issue Good for newcomers ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#597 add border behind pfp kuba-04/notedeck
1 participant
@jb55