#597 add border behind pfp

[kuba-04]

fixes #597

[jb55]

I think it would make more sense to add this as an option on ProfilePic. We wouldn't always want a border. We should also just put a full circle behind it instead of just a border, because just a stroke seems to be creating artifacts around the border of the image

[kernelkind]

Can also experiment with Painter::round_to_pixel

[kuba-04]

Sure!

1. I just added that full circle behind. We may avoid adding inner circle if not image is available. Please let me know which one you like more:

A) version with inner circle:

B) version without inner circle:

2. As for the option for ProfilePic struct, I have some problem with this. Maybe I misunderstood, but if I add it to the struct, then there will be many places to choose on that option. It actually showed me how many times we have to create a new ProfilePic, do we need so many of them? I will double check that. But for this issue basically my question is: where do we want to decide on that border to exist or not? EDIT: To be more precise with 'where', we can decide in this match:

or you have plans to customize this border/circle with some feature which will load the color or something from the profile info..

btw, these are the places of creating new ProfilePic:

[kuba-04]

Just seen your comment:

Can also experiment with Painter::round_to_pixel

tried now, so far it didn't help. I will try again later

[jb55]

On Wed, Jan 29, 2025 at 09:36:06AM -0800, kuba-04 wrote: Sure! 1. I just added that full circle behind. We may avoid adding inner circle if not image is available. Please let me know which one you like more: A) version with inner circle:  B) version without inner circle: 

A looks good to me

2. As for the option for ProfilePic struct, I have some problem with this. Maybe I misunderstood, but id I add it to the struct, then there will be many places to choose on that option. It actually showed me how many times we have to create a new ProfilePic, hmm do we need some many of them? I will double check that. But for this issue basically my question is: **where do we want to decide on that border to exist or not?**

you set it via a method on ProfilePic. something like ui.add(ProfilePic::new().border(2.0))

[kuba-04]

you set it via a method on ProfilePic. something like
ui.add(ProfilePic::new().border(2.0))

thanks, I am here to learn from you guys.

Added, but not sure if the size is good in all places

[jb55]

On Thu, Jan 30, 2025 at 10:16:36AM -0800, kuba-04 wrote: > you set it via a method on ProfilePic. something like > ui.add(ProfilePic::new().border(2.0)) thanks, I am here to learn from you guys. Added, but not sure if the size is good in all places

I'll take a look again soon, I'm just working on our alpha 2 release atm

[jb55]

thanks! sorry for the delay, I added a commit on top of this to make it look bit cleaner:

9dd33d5

[kuba-04]

nice! if you don't mind I am gonna pick up more issues for notedeck as I am using the app regularly.

[jb55]

great!