Enable access for token refresh #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2022 22:42
To enable access of credentials in case of token refresh
To enable immediate storing and/or access of the newly refreshed token.
daneden
requested changes
Jun 6, 2022
Co-authored-by: Daniel Eden <dan.eden@me.com>
daneden
requested changes
Jun 7, 2022
Sources/Twift.swift
Outdated
|
|
||
| internal let decoder: JSONDecoder | ||
| internal let encoder: JSONEncoder | ||
|
|
||
| /// Initialise an instance with the specified authentication type | ||
| public init(_ authenticationType: AuthenticationType) { | ||
| public init(_ authenticationType: AuthenticationType, onRefresh: (()-> Void)? = nil) { |
There was a problem hiding this comment.
Seeing this now, it actually makes more sense to have onRefresh associated with the AuthenticationType:
enum AuthenticationType {
case oauth2User(user: OAuth2User, onRefresh: (() -> Void)?)
...
}Alternatively, we might want to move to different initialisers for different authentication types. That might actually be nicer from an author perspective.
There was a problem hiding this comment.
I see, yeah, makes sense
Should we then even make it non-optional? I am not sure what the case would be where one would not need a refresh of the token?
I made some changes to the refreshOAuth2AccessToken and moved refreshCompletion from the init to the AuthenticationType
Co-authored-by: Daniel Eden <dan.eden@me.com>
…roblack/Twift into enable-access-for-token-refresh
|
Also, made some changes to the tests and all instances where |
daneden
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issue, enabling access of the
oauthUseralong with the addition of an optional callback.#30
Hope it makes sense and this is what you had in mind 🙌