-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable access for token refresh #31
Merged
daneden
merged 15 commits into
daneden:main
from
emin-grbo:enable-access-for-token-refresh
Jun 10, 2022
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
aa37159
Add public oauthUser property
8329d43
Add optional callback method to token refresh
13957ef
make oauthUser computed
emin-grbo 23f4e3c
add optional callback for refresh in module init
db9ed55
remove optional unwrap of completion
emin-grbo b200851
extend .oauth2UserAuth to return a tuple
6bd4a4c
extend `oauth2UserAuth` to allow for refresh callback
b2d4e22
move refreshCompletion from init to oauthUserAuth authentication
5013577
extend tests to work with new refresh callbacl
ccfb689
Merge branch 'enable-access-for-token-refresh' of https://github.com/…
00db078
Housekeeping
daneden 6a3e060
Fix failing tests by ensuring test scheme uses test environment variable
daneden 0ce9260
Add documentation for app-only bearer token initialisation
daneden 2fb94b1
Update readme to reflect new convenience initialisers
daneden 4becb8d
Update test app
daneden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this now, it actually makes more sense to have
onRefresh
associated with theAuthenticationType
:Alternatively, we might want to move to different initialisers for different authentication types. That might actually be nicer from an author perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, yeah, makes sense
Should we then even make it non-optional? I am not sure what the case would be where one would not need a refresh of the token?
I made some changes to the
refreshOAuth2AccessToken
and movedrefreshCompletion
from the init to theAuthenticationType