Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Tests are failing #135

Open
soxofaan opened this issue Dec 19, 2022 · 4 comments
Open

Tests are failing #135

soxofaan opened this issue Dec 19, 2022 · 4 comments

Comments

@soxofaan
Copy link
Contributor

I'm trying to run the tests and they seem to be failing.
For example see the github actions runs in my fork: https://github.com/soxofaan/pelican-jupyter/actions/workflows/test.yml

It seems there are various compatibility issues with dependencies

soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should address
    ImportError: cannot import name 'contextfilter' from 'jinja2'

ref: jupyter/nbconvert#1742
@danielfrg
Copy link
Owner

Yes, sadly I am not using this library anymore personally so i dont have time to update fix those issues.

soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
@soxofaan
Copy link
Contributor Author

Ok, no problem

Should https://github.com/danielfrg/pelican-jupyter be considered "unmaintained", or would you still accept a PR if I manage to figure this out?

soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should address
    ModuleNotFoundError: No module named 'ipython_genutils'

ref: jupyter/nbconvert#1725
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should addess
    LiquidTags.extendMarkdown() missing 1 required positional argument: 'md_globals'

ref: pelican-plugins/liquid-tags#19
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should address
    ModuleNotFoundError: No module named 'ipython_genutils'

ref: jupyter/nbconvert#1725
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should addess
    LiquidTags.extendMarkdown() missing 1 required positional argument: 'md_globals'

ref: pelican-plugins/liquid-tags#19
@danielfrg
Copy link
Owner

I totally accept PRs and make releases with those when I have time but I think it should be considered unmaintened.

I am happy to add you to it if you want to be a mantainer!

@soxofaan
Copy link
Contributor Author

I am happy to add you to it if you want to be a mantainer!

@danielfrg thanks for offering that. Unfortunately, to be honest, I also have very limited bandwidth to take up the role/responsibility of maintaining this package I'm afraid. I only use it for a small, low frequency side project.

I think I fixed the broken test issue in #136 by the way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants