Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after fresh install #19

Closed
jaapnoordzij opened this issue Jul 27, 2022 · 3 comments · Fixed by #20
Closed

Error after fresh install #19

jaapnoordzij opened this issue Jul 27, 2022 · 3 comments · Fixed by #20

Comments

@jaapnoordzij
Copy link

  • Install a new Pelican with Markdown
  • Create a skeleton site with pelican-quickstart
  • Add a 1 or 2 line content file as test.md
  • Install this plugin with pip and set the PLUGINS var
    Generate the site with pelican .

Generates an error:
ERROR Could not process content/test.md log.py:96
LiquidTags.extendMarkdown() missing 1 required positional argument: 'md_globals'
Done: Processed 0 articles, 0 drafts, 0 hidden articles, 0 pages, 0 hidden pages and 0 draft pages in 0.09 seconds.

@mirekdlugosz
Copy link
Collaborator

I can reproduce the problem. Thanks for reporting!

Looks like liquid-tags expects md_globals argument, which was deprecated in Markdown package back in 2018. Markdown finally removed backwards-compatibility in release 3.4, released about two weeks ago.

We never use that variable, so fix is easy, but there's another issue under it. I will need more time to debug that.

In the meantime, you can downgrade markdown to last known working version:

pip install markdown==3.3.7

By the way, you don't need to include liquid_tags in PLUGINS var (unless you still use old-style pelican plugin). However, you should set LIQUID_TAGS variable for plugin to do anything interesting.

@jaapnoordzij
Copy link
Author

Thank you for the workaround!

@mirekdlugosz
Copy link
Collaborator

@jaapnoordzij I have now merged the fix and released new version of a plugin. I can no longer reproduce the problem on fresh install.

You should now be able to update markdown package. Let us know if you encounter more issues.

soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should addess
    LiquidTags.extendMarkdown() missing 1 required positional argument: 'md_globals'

ref: pelican-plugins/liquid-tags#19
soxofaan added a commit to soxofaan/pelican-jupyter that referenced this issue Dec 19, 2022
Should addess
    LiquidTags.extendMarkdown() missing 1 required positional argument: 'md_globals'

ref: pelican-plugins/liquid-tags#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants