Fixes #5 Symbol issues #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to my misunderstanding of _exactly_ how to use `printf()`'s [parameter field](https://en.wikipedia.org/wiki/Printf_format_string#Parameter_field), then under some PGTBOX(...) settings and with certain time axis range, the 'sprintf(...)' would trigger an `__libc_fatal(...)` - terminating the user's application. The fatal error was only triggered if DAY number was to be displayed and DAY number was non-negative. By a simple permutation of the calling arguments and the parameter field(s) in the format strings this should not happen anymore.
The triangles 7, 13 were pointing the wrong way and symbol 15 is the star of David formed by overplotting two open triangles offset a little bit
Symbols 12 and 18 now are five-point stars, open and filled. Symbol 20 was entered as seven-point star but it should be a small open circle. Already changed it from _giza_star() => _giza_circle() but symbols 20-27 are a bit off anyway, so that's going to be fixed in a different commit.
The open circles are now exponentially scaled and drawn with a slightly thinner line than before
Symbol danieljprice#19 was not a hexagon with a cross but a larger open square than danieljprice#6. The squares are also drawn with a slightly thinner line.
The arrows looked markedly smaller in giza than on the PGPLOT original. Scaled them up a bit.
They came out (noticeably) smaller in giza than in PGPLOT as far as I could tell.
|
image from Karl |
|
all looks good to me |
|
Those are looking good.
Maybe some sizing changes?
Karl
… On 9 Nov 2018, at 10:16 am, Daniel Price ***@***.***> wrote:
all looks good to me
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOnymmXoYtcpdGnyeugBxoibuJJhNgIwks5utLtHgaJpZM4YUzx_>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at resolving the symbol issues raised in @karlgrazebrook's Issue.
I attach a screenshot of how pgdemo2, 2nd screen renders on my system. Compare to the differences shown here.
I think that there are a few other symbols that could do with a bit of scaling up - but let's check these ones first.