Skip to content

Commit

Permalink
fix: ensure primary content areas wrapped in main landmark element (n…
Browse files Browse the repository at this point in the history
…odejs#3340)

The pages on the site are not wrapped in a <main> sectioning element, so the goal of this PR is to ensure that each page includes this semantic markup. Including a <main> landmark on a page improves accessibility by helping assistive tech quickly identify the primary content of the page.
  • Loading branch information
jendowns authored Feb 17, 2021
1 parent 8bb3865 commit 9305e9d
Show file tree
Hide file tree
Showing 16 changed files with 34 additions and 32 deletions.
4 changes: 2 additions & 2 deletions layouts/about-release-schedule.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container has-side-nav">

{{> navigation key='about'}}
Expand All @@ -26,7 +26,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/about.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container has-side-nav">

{{> navigation key='about'}}
Expand All @@ -15,7 +15,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
6 changes: 4 additions & 2 deletions layouts/black-lives-matter.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
<html lang="{{site.locale}}"{{#if site.rtl}} dir="rtl"{{/if}}>
{{> blm-html-head }}
<body>
{{> blm-header }}
{{{ contents }}}
<main>
{{> blm-header }}
{{{ contents }}}
</main>
{{> blm-footer }}
</body>
</html>
4 changes: 2 additions & 2 deletions layouts/blog-index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
<h2>News from {{ pagination.year }}</h2>

Expand Down Expand Up @@ -40,7 +40,7 @@
</nav>
{{/if}}
</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/blog-post.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">

<article>
Expand All @@ -18,7 +18,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/category-index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
{{#if title}}
<h2>{{ title }}</h2>
Expand All @@ -27,7 +27,7 @@
</ul>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/contribute.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container has-side-nav">

{{> navigation key='getinvolved'}}
Expand All @@ -15,7 +15,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/docs.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container has-side-nav">

{{> navigation key='docs'}}
Expand All @@ -17,7 +17,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/download-current.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
<article>
<div class="download-header">
Expand All @@ -18,7 +18,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/download-releases.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
<article>
<h1>{{title}}</h1>
Expand Down Expand Up @@ -58,7 +58,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/download.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
<article>
<div class="download-header">
Expand All @@ -18,7 +18,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">

<div id="home-intro">
Expand Down Expand Up @@ -77,7 +77,7 @@
</div>

</div>
</div>
</main>

{{> footer className="no-margin-top" }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/knowledge-base-index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container has-side-nav">

{{!-- {{> navigation key='docs'}} --}}
Expand All @@ -23,7 +23,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/knowledge-post.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">

<article>
Expand All @@ -18,7 +18,7 @@
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/page.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">
{{{ contents }}}
</div>
</div>
</main>

{{> footer }}
</body>
Expand Down
4 changes: 2 additions & 2 deletions layouts/security.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
<body>
{{> header }}

<div id="main">
<main id="main">
<div class="container">

<article>
{{{ contents }}}
</article>

</div>
</div>
</main>

{{> footer }}
</body>
Expand Down

0 comments on commit 9305e9d

Please sign in to comment.