-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove renderfile property from notcurses_option #2081
Labels
Milestone
Comments
dankamongmen
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 21, 2021
24 tasks
in @igo95862 's wrappers, we have: if (NULL != render_fd_object)
{
long render_fd = GNU_PY_LONG_CHECK(render_fd_object);
FILE *renderfp = fdopen((int)render_fd, "w");
if (NULL == renderfp)
{
PyErr_SetString(PyExc_ValueError, "Failed to open render file descriptor.");
return NULL;
}
options.renderfp = renderfp;
} it looks like this is setting up the |
dankamongmen
added a commit
that referenced
this issue
Aug 21, 2021
alright. removed it from C implementation, new python, and rust. |
i've added a note to remove the field for ABI3 in #1777. |
dankamongmen
added a commit
that referenced
this issue
Aug 22, 2021
dankamongmen
added a commit
that referenced
this issue
Aug 22, 2021
dankamongmen
added a commit
that referenced
this issue
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
renderfile
was added very early in Notcurses development, probably in 2019, and I've never used it once. It's time for it to go. Don't break ABI by pulling it out yet, but mark it as deprecated in the header file and docs, and check for its presence. If it is defined, ignore it and print a diagnostic. Remove it in ABI3.The text was updated successfully, but these errors were encountered: