Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove renderfile property from notcurses_option #2081

Closed
dankamongmen opened this issue Aug 21, 2021 · 3 comments
Closed

remove renderfile property from notcurses_option #2081

dankamongmen opened this issue Aug 21, 2021 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@dankamongmen
Copy link
Owner

renderfile was added very early in Notcurses development, probably in 2019, and I've never used it once. It's time for it to go. Don't break ABI by pulling it out yet, but mark it as deprecated in the header file and docs, and check for its presence. If it is defined, ignore it and print a diagnostic. Remove it in ABI3.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 21, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Aug 21, 2021
@dankamongmen dankamongmen self-assigned this Aug 21, 2021
@dankamongmen
Copy link
Owner Author

in @igo95862 's wrappers, we have:

    if (NULL != render_fd_object)                                                                                            
    {                                                                                                                        
        long render_fd = GNU_PY_LONG_CHECK(render_fd_object);                                                                
                                                                                                                             
        FILE *renderfp = fdopen((int)render_fd, "w");                                                                        
        if (NULL == renderfp)                                                                                                
        {                                                                                                                    
            PyErr_SetString(PyExc_ValueError, "Failed to open render file descriptor.");                                     
            return NULL;                                                                                                     
        }                                                                                                                    
                                                                                                                             
        options.renderfp = renderfp;                                                                                         
    }           

it looks like this is setting up the renderfp option, but i'm not sure exactly what render_fd_object does, hrmmm. ok, it's coming in from the kwds tuples. so i guess we just want to remove that keypair?

@dankamongmen
Copy link
Owner Author

alright. removed it from C implementation, new python, and rust.

@dankamongmen
Copy link
Owner Author

i've added a note to remove the field for ABI3 in #1777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant