-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear all deprecated elements before calling it abi3 #1777
Labels
Milestone
Comments
so ought we deprecate |
we're removing the deprecated |
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777.
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777.
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777.
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 11, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 12, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777.
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
dankamongmen
added a commit
that referenced
this issue
Oct 16, 2021
* [heuristics] GNU screen 4x never has rgb * [BitmapSmoothMove] only WARN in test until sixel supports this #2258 * add minimal example for #2266 * contour: enable sextants * interp PoC: clean up ncvisual #2266 * ncselector_options: constify string arguments * Constify strings in selector/mselector_items Use internal types to track items within the selector/mselector widgets, rather than pressing the user-provided item structs into double-duty. With this change, we can constify the strings within those user-provided items. Do so, also removing the internal-side elements. Update documentation. Closes #2267. * constify ncmenu_item/_section strings * Use Windows pipes for input readiness notification (#2263) * [windows] use CreatePipe for input #2244 * [input] read and write to Windows readiness handles #2244 * inputready_fd: not on windows, alas * for now, if it's on windows, it's windows terminal #2248 * tabbed janitorial work clean up memory leak of tab names ignore NCTYPE_RELEASE in tabbed PoC constify strings in nctabbed_options * notcurses-demo FPS graph: back to straight seconds * [info] expand some emoji into proper literals * drop textplay PoC * remove poc for issue #2266 * constify ncselector_item reference fix #2270 * [ncplayer] restore pause functionality with NCTYPE_RELEASE * stop pushing termtype to interrogate_terminfo * menu PoC: ignore NCTYPE_RELEASE * properly name Windows Terminal * [windows] HANDLE, not PHANDLE * ncvisual_render -> ncvisual_blit (core/test) #1462 * ncvisual_render -> ncvisual_blit (docs) * ncvisual_render -> ncvisual_blit (nctetris) * [keller] fix up for ncvisual_blit() #1462 * stacking tests: ncvisual_render() -> ncvisual_blit() #1462 * all PoCs: ncvisual_render -> ncvisual_blit #1462 * restore ncvisual_inflate(), for now * pixel PoC / ncneofetch -> ncvisual_blit() #1462 * notcurses-info: ncvisual_blit, inline all emoji #1462 * rotate PoCpp: ncvisual_blit() #1462 * xray/grid: ncvisual_blit() #1462 * remove last instances of ncvisual_render() #1462 * remove old-style notcurses_ rendering functions Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777. * ncstrwidth() becomes static inline wrapper #1777 * remove deprecated ncvisual_subtitle() * kill ncvisual_inflate(), long deprecated #1777 * remove deprecated palette256 wrappers #1777 * kill ncplane_new() #1777 * remove deprecated renderfp field from notcurses_options #1777 * reorder ncstats fields to match documentation #1777 * kill deprecated style functions #1777 * ncplane_move{top, bottom} become static inline #1777 * fix up move_above()/move_below() #1777 * ncplane_pixelgeom -> ncplane_pixel_geom() #1777 * ncstyle functions ought return uint16_t #1777 #2200 * ncvisualplane_create: provide new pile functionality #1462 * introduce ncvisual_blit() #1462 * reduce ncvisual_render() to wrapper around ncvisual_blit() #1462 * convert most ncvisual_render()s to ncvisual_blit() #1642 Co-authored-by: joseLuís <joseluis@andamira.net>
adding to the list, in case the pointer types can be normalized:
|
Merged
dankamongmen
added a commit
that referenced
this issue
Nov 9, 2021
these both got done |
dankamongmen
added a commit
that referenced
this issue
Nov 9, 2021
Long-planned changes for API/ABI3 #1777 * remove old-style notcurses_ rendering functions * Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). * ncstrwidth() becomes static inline wrapper #1777 * remove deprecated ncvisual_subtitle() * kill ncvisual_inflate(), long deprecated #1777 * remove deprecated palette256 wrappers #1777 * kill ncplane_new() #1777 * remove deprecated renderfp field from notcurses_options #1777 * reorder ncstats fields to match documentation #1777 * kill deprecated style functions #1777 * ncplane_move{top, bottom} become static inline #1777 ** ncplane_pixelgeom -> ncplane_pixel_geom() #1777 * ncstyle functions ought return uint16_t #1777 #2200 * ncvisualplane_create: provide new pile functionality #1462 * [heuristics] GNU screen 4x never has rgb * [BitmapSmoothMove] only WARN in test until sixel supports this #2258 * contour: enable sextants * interp PoC: clean up ncvisual #2266 * ncselector_options: constify string arguments * Constify strings in selector/mselector_items Use internal types to track items within the selector/mselector widgets, rather than pressing the user-provided item structs into double-duty. With this change, we can constify the strings within those user-provided items. Do so, also removing the internal-side elements. Update documentation. Closes #2267. * constify ncmenu_item/_section strings * constify strings in nctabbed_options * notcurses-demo FPS graph: back to straight seconds * remove unused wchar_from_utf8() * nstrwidth_valid(): properly initialize bytes/width * [ncneofetch] use GetSystemInfo on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
There's been a good deal of deprecated material collecting, which we can't remove until ABI3, intended to be marked by 3.0.0.
I've been trying to move it to the bottom of
notcurses.h
andncdirect.h
, but we ought do a final pass.All shipped code ought already have moved off of deprecated material, of course.
Also look for anything we can move to a
static inline
and away from a symbol. Symbols can't be promoted to static inline, or else old programs will stop linking.a partial list, growing as things change:
renderfile
fromnotcurses_options
remove renderfile property from notcurses_option #2081notcurses_can_*()
functions tostatic inline
wrappers aroundnotcurses_capabilities()
add missing capabilities functions to direct mode #1768inline
ncdirect_can_*()
functions tostatic inline
s aroundncdirect_capabilities()
add missing capabilities functions to direct mode #1768((deprecated))
CELL_ALPHA_*
definitionspalette256
typenotcurses_render_to_buffer()
,notcurses_render_to_file()
notcurses_render()
becomesstatic inline
nccell_width()
is removedncstats
to match documentationncdirect_getc()
andnotcurses_getc()
pull sigset_t out of API #1967NCKEY
constants to match the kitty protocol (see take advantage of kitty keyboard protocol #2131)ncstrwidth
becomesstatic inline
(see add ncstrwidth() that returns column width of valid prefix #2153)notcurses_getc()
andncdirect_getc()
uint16_t
(see fixing stylemask related functions parameter & return type #2200)ncplane_move_below()
andncplane_move_above()
ought be modified to acceptNULL
, with obvious implications, andncplane_move_top()
andncplane_move_bottom()
can be rewritten asstatic inlines
around them, cutting two symbolsncplane_pixelgeom
toncplane_pixel_geom
ncplane_moverel
toncplane_move_rel
int
tounsigned
ncpile*
(fromncplane*
) instead ofnotcurses*
forncvisual_render()
,NULL
for new pile (ncvisual_render needs be pile-aware #1462)notcurses_get()
ought take an absolute deadline rather than a delay bound. kill offdelaybound_to_deadline()
once this is done (see need time against CLOCK_MONOTONIC with musl libc #2302)ncdirect_rounded_box()
andncdirect_double_box()
ought becomestatic inline
notcurses_top()
andnotcurses_bottom()
can become static inlines aroundncpile_{top, bottom}()
ncmetric()
can becomestatic inline
you know, maybe we don't want to nuke everything that's deprecated; where possible, we could keep them as (deprecated)
static inline
s, so a recompile still works. maybe.rejected:
*
(dumb idea. this would just require traversing all the checks inncplane_erase()
becomes static inline aroundncplane_erase_region()
, which calls the current internalncplane_erase()
for that special case (it's a good optimization)ncplane_erase_region()
for no good reason)the whole point ofnotcurses_getvec()
can become static inlinenotcurses_getvec()
is speed, and we can be faster if we embed this behind the lockingThe text was updated successfully, but these errors were encountered: