Use Windows pipes for input readiness notification #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankamongmen
force-pushed
the
dankamongmen/windows-pipes
branch
from
bb5c2ec to
f1148ac
Compare
dankamongmen
force-pushed
the
dankamongmen/windows-pipes
branch
from
f1148ac to
f93faee
Compare
|
Do you need WIndows pipes if you use AF_Unix? |
dankamongmen
force-pushed
the
dankamongmen/windows-pipes
branch
from
6ca801f to
4a3d021
Compare
|
i just went and tested this, and it breaks initialization (on windows). so don't merge it yet. |
|
ok, got it working |
|
|
|
I was thinking that before WSL2 was created, a TCP/IP pipe was needed for Docker to integrate with WSL1. When AF_Unix came out, eventually that was also provided as an option, and was a better integration than the pipe. Based on this, I was considering that notcurses might get into a similar position for Windows but if you get better perf using a pipe, i'm all for it. |
dankamongmen
added a commit
that referenced
this pull request
Oct 16, 2021
* [heuristics] GNU screen 4x never has rgb * [BitmapSmoothMove] only WARN in test until sixel supports this #2258 * add minimal example for #2266 * contour: enable sextants * interp PoC: clean up ncvisual #2266 * ncselector_options: constify string arguments * Constify strings in selector/mselector_items Use internal types to track items within the selector/mselector widgets, rather than pressing the user-provided item structs into double-duty. With this change, we can constify the strings within those user-provided items. Do so, also removing the internal-side elements. Update documentation. Closes #2267. * constify ncmenu_item/_section strings * Use Windows pipes for input readiness notification (#2263) * [windows] use CreatePipe for input #2244 * [input] read and write to Windows readiness handles #2244 * inputready_fd: not on windows, alas * for now, if it's on windows, it's windows terminal #2248 * tabbed janitorial work clean up memory leak of tab names ignore NCTYPE_RELEASE in tabbed PoC constify strings in nctabbed_options * notcurses-demo FPS graph: back to straight seconds * [info] expand some emoji into proper literals * drop textplay PoC * remove poc for issue #2266 * constify ncselector_item reference fix #2270 * [ncplayer] restore pause functionality with NCTYPE_RELEASE * stop pushing termtype to interrogate_terminfo * menu PoC: ignore NCTYPE_RELEASE * properly name Windows Terminal * [windows] HANDLE, not PHANDLE * ncvisual_render -> ncvisual_blit (core/test) #1462 * ncvisual_render -> ncvisual_blit (docs) * ncvisual_render -> ncvisual_blit (nctetris) * [keller] fix up for ncvisual_blit() #1462 * stacking tests: ncvisual_render() -> ncvisual_blit() #1462 * all PoCs: ncvisual_render -> ncvisual_blit #1462 * restore ncvisual_inflate(), for now * pixel PoC / ncneofetch -> ncvisual_blit() #1462 * notcurses-info: ncvisual_blit, inline all emoji #1462 * rotate PoCpp: ncvisual_blit() #1462 * xray/grid: ncvisual_blit() #1462 * remove last instances of ncvisual_render() #1462 * remove old-style notcurses_ rendering functions Make notcurses_render() a static inline wrapper around ncpile_render(). Remove the deprecated notcurses_render_to_file() and ncpile_render_to_file(). ABI3 work #1777. * ncstrwidth() becomes static inline wrapper #1777 * remove deprecated ncvisual_subtitle() * kill ncvisual_inflate(), long deprecated #1777 * remove deprecated palette256 wrappers #1777 * kill ncplane_new() #1777 * remove deprecated renderfp field from notcurses_options #1777 * reorder ncstats fields to match documentation #1777 * kill deprecated style functions #1777 * ncplane_move{top, bottom} become static inline #1777 * fix up move_above()/move_below() #1777 * ncplane_pixelgeom -> ncplane_pixel_geom() #1777 * ncstyle functions ought return uint16_t #1777 #2200 * ncvisualplane_create: provide new pile functionality #1462 * introduce ncvisual_blit() #1462 * reduce ncvisual_render() to wrapper around ncvisual_blit() #1462 * convert most ncvisual_render()s to ncvisual_blit() #1642 Co-authored-by: joseLuís <joseluis@andamira.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our new event subsystem relies on pipes for readiness testing. On Windows, this means
CreatePipe()andHANDLEs. #2244